Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Separate "Engine" and "Topology" layers #293

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

nathanwbrei
Copy link
Collaborator

JANA2's internal architecture can now be divided into four distinct layers: {Plugins, Components, Topology, Engine}

In practice, this mainly consists of moving files around for now. Several abstractions have also changed slightly:

  • JProcessingController and JArrowProcessingController have merged, as this level of indirection is obsolete and holding up some overdue improvements to JArrowProcessingController. Similarly, JPerfSummary and JArrowPerfSummary, which always had an awkward relationship with each other, have merged.
  • The anemic JArrowTopology class has rejoined JTopologyBuilder, cleaning up the service dependency chain as follows:

JPluginLoader <-> JComponentManager <- JTopologyBuilder <- JProcessingController

@nathanwbrei nathanwbrei merged commit c1378b3 into master Apr 29, 2024
3 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_reorganize branch April 29, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant