Small fixes inspired by debugging eicrecon #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwbrei
force-pushed
the
nbrei_eicrecon_fixes_2
branch
from
af7301d to
85d8b87
Compare
One of the use cases for AutoActivator is debugging factories that might be excepting, but the exceptions are being swallowed by the caller.
nathanwbrei
force-pushed
the
nbrei_eicrecon_fixes_2
branch
from
85d8b87 to
df65224
Compare
This doesn't make our factories safer or more correct, and may be responsible for the very simple test case that mysteriously hangs, but only during the Docker CI job.
|
Here's a fun rabbit hole: Apparently std::call_once is not always exception-safe?!? Particularly the libstdc++ implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.