Arrow refactoring #270
Merged
Arrow refactoring #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excise KArrow
This information isn't set on a per-arrow basis anyway, and the only place it is used is in JWorker
- Add asserts - Initialize pool - Change queue ownership - Fix report formatting
This fixes a new problem with reservations, but also an old problem with a worker getting stuck doing no-op merges
Needs a lot more work, and there's not much of a point if we can do everything with PipelineArrow and JunctionArrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Arrow abstractions in anticipation of needing timeslices in EICrecon. In theory this shouldn't affect anything user-facing.