Bugfix: SetDefaultParameter no longer puts duplicate copies in vector #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwbrei
requested changes
Oct 20, 2023
| Parse(param->GetValue(),t); | ||
| val = t; | ||
| Parse(param->GetValue(),t1); | ||
| val = t1; |
There was a problem hiding this comment.
This should fix the bug, but I think it misses the root cause, which is that the vector version of Parse() is appending to t without clearing it first.
There was a problem hiding this comment.
We might run into other bugs with Parse<std::string, std::vector<T> val>() down the road if we don't clear val
nathanwbrei
approved these changes
Oct 20, 2023
nathanwbrei
deleted the
AyanRoy16_issue_256_duplication_of_vector_default_parameters
branch
nathanwbrei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is made to make sure that the input vector reference is not duplicated.
[x] Code changes made
[x] Test case added