Address issue #233: Resolve floating-point JParameter stringification round-trip problems #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The specializations of Stringify for float and double were not actually specializations. Rather they were a separate base template. - The specializations weren't getting called by the test cases - The specializations contained a bug where the stringstream was not cleared before new data was piped in - The cleanest exact representation of a floating point type T comes from setprecision(std::numerics_limits<T>::max_digits10), not from setprecision(30).
These contain a logic error resulting in lots of spurious "loses equality after stringification" warnings. We don't want fuzzy floating-point equality here anyhow -- we want all parameter values to be bit-for-bit exact. See Issue #233 for discussion.
nathanwbrei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling the precision for float and double when stringified. New specialization for float and double has been added.
[X] New test cases added.
[X] Existing test cases passed