Merge pull request #191 from JeffersonLab/davidl_StringParameters

Skip parsing from std::string type

src/libraries/JANA/Services/JParameterManager.h

@@ -292,7 +292,6 @@ inline T JParameterManager::RegisterParameter(std::string name, const T default_
 
 
 /// @brief Logic for parsing different types in a generic way
-/// @throws JException in case parsing fails.
 template <typename T>
 inline T JParameterManager::Parse(const std::string& value) {
     std::stringstream ss(value);
@@ -301,6 +300,12 @@ inline T JParameterManager::Parse(const std::string& value) {
     return val;
 }
 
+/// @brief Specialization for handling strings that don't need parsing
+template <>
+inline std::string JParameterManager::Parse(const std::string& value) {
+    return std::string(value);
+}
+
 /// @brief Specialization for bool
 template <>
 inline bool JParameterManager::Parse(const std::string& value) {

src/programs/tests/JParameterManagerTests.cc

@@ -85,6 +85,26 @@ TEST_CASE("JParameterManager::SetDefaultParameter") {
         jpm.SetDefaultParameter("testing:dummy_var_2", zz);
         REQUIRE(zz == 77);
     }
+
+    SECTION("Multiple calls to check strings with spaces") {
+
+        // basic string test
+        std::string x = "MyStringValue";
+        jpm.SetDefaultParameter("testing:dummy_var", x);
+        REQUIRE(x == "MyStringValue");
+
+        // string with spaces
+        std::string y = "My String Value With Spaces";
+        auto p = jpm.SetDefaultParameter("testing:dummy_var2", y);
+        REQUIRE(p->GetValue() == "My String Value With Spaces");
+
+        // Stringify returns identical string
+        REQUIRE( jpm.Stringify("My String Value With Spaces") == "My String Value With Spaces" );
+
+        // Parse returns identical string
+        std::string z = "My String Value With Spaces";
+        REQUIRE( jpm.Parse<std::string>(z) == "My String Value With Spaces" );
+    }
 }