Fix memory leak in JFactoryPodioT::Set

This resolves issue #235.
JeffersonLab · Nov 21, 2023 · 160bcdb · 160bcdb
1 parent a229aa7
commit 160bcdb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/libraries/JANA/Podio/JFactoryPodioT.h b/src/libraries/JANA/Podio/JFactoryPodioT.h
@@ -193,6 +193,7 @@ void JFactoryPodioT<T>::Set(const std::vector<T*>& aData) {
     if (mIsSubsetCollection) collection.setSubsetCollection(true);
     for (T* item : aData) {
         collection.push_back(*item);
+        delete item;
     }
     SetCollection(std::move(collection));
 }
@@ -203,6 +204,7 @@ void JFactoryPodioT<T>::Set(std::vector<T*>&& aData) {
     if (mIsSubsetCollection) collection.setSubsetCollection(true);
     for (T* item : aData) {
         collection.push_back(*item);
+        delete item;
     }
     SetCollection(std::move(collection));
 }
@@ -212,6 +214,7 @@ void JFactoryPodioT<T>::Insert(T* aDatum) {
     CollectionT collection;
     if (mIsSubsetCollection) collection->setSubsetCollection(true);
     collection->push_back(*aDatum);
+    delete aDatum;
     SetCollection(std::move(collection));
 }