Fixes of event type sorting for pattern matching, encapsulating logic in EventTypePatternMatchFrame
#2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `EventTypePatternMatchFrame` commit 794bd44 Author: Sergio Amaral <[email protected]> Date: Mon Oct 23 00:33:20 2023 +0100 Updates tests to include interfaces scenario commit d116879 Author: Sergio Amaral <[email protected]> Date: Fri Oct 20 17:04:33 2023 +0100 Updates order to take into consideration type and interface hierarchies commit 45f416a Author: Sergio Amaral <[email protected]> Date: Thu Oct 19 17:12:34 2023 +0100 Implements of EventTypeComparer to version that pass all combination and permutation tests Note: Only consider event type hierarchy, overlooking any interfaces implemented by event types. commit fc68200 Author: Sergio Amaral <[email protected]> Date: Thu Oct 19 16:49:25 2023 +0100 Adds expectation that sort has same elements as original collection commit 06ab305 Author: Jeremy D. Miller <[email protected]> Date: Thu Oct 19 08:40:13 2023 -0500 adjustment to the new event handler frame ordering fix commit 35d2a5c Author: Sergio Amaral <[email protected]> Date: Mon Oct 16 11:01:32 2023 +0100 Fixes minor repetition in test class name commit dc8578c Author: Sergio Amaral <[email protected]> Date: Mon Oct 16 10:57:51 2023 +0100 Simplifies of event type sorting for pattern matching by encapsulating logic in `EventTypePatternMatchFrame` Adds support for having event types as interfaces of that is ever a valid scenario. Adjust tests in accordance to functional changes. commit b72a431 Author: Sergio Amaral <[email protected]> Date: Fri Oct 13 18:17:18 2023 +0100 Fixes `EventTypeComparer` implementation to reliably sort types for codegen and implements extensive sorting tests Disclaimer: Comparer implementation may not work properly if interface types are used in projections. Current implementation relies on using entire type hierarchy for sorting, starting from base type, within same hierarchy level type name sort is used. commit 83eb9e2 Author: Sergio Amaral <[email protected]> Date: Wed Oct 11 15:20:16 2023 +0100 Adds test scenario to repoduce non-deterministic code generation issue (will only fail sometimes)
|
After discussion with @jeremydmiller, still pending providing an integration test for the scenario, but submitting here for review of implementation and potential consideration for the upcoming 6.3.0 release. |
…es in projections Confirms that order of generated code is correct, processing the most specific registered type to the event generated.
|
Integration test covering this scenario has been added, please let me know if it meets the expectations. |
|
Thanks for merging this one. When can I expect a release with it included? |
|
@svrx, I think that it should be available in 6.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrade to version 6 some issue have been identified with compilation of generated code.
When a projection depends on events from different levels of the same inheritance chain, the sorting of methods performed during code generation has been found to be non-deterministic.
See more in #2749.
Current PR provides fixes and tests for such scenario.