This repository has been archived by the owner on May 31, 2020. It is now read-only.
Warning Points #28
Open
Warning Points #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a case logging & log page, Uses a modified reimbursement_log table which uses the statement found here: https://pastebin.com/vBbV11qD
Fix for warning pointsnot being added and error 'column can not be null' has been fixed.
Jason2605
reviewed
May 3, 2017
notes.php
Outdated
| echo '<td>'."<input class='form-control' type=text name=note value=''> </td>"; | ||
| echo '<td>'."<input class='btn btn-primary btn-outline' type=submit name=update value=Update".'> </td>'; | ||
| echo "<td style='display:none;'>".'<input type=hidden name=hidden value='.$row['uid'].'> </td>'; | ||
| echo "<td style='display:none;'>".'<input type=hidden name=hidden value='.$row['playerid'].'> </td>'; |
There was a problem hiding this comment.
I prefer the use of UID here over playerid due to 5.0 changing the table to be pid.
|
I will try later when I get home to update it with the UID.
…On Wed, May 3, 2017 at 10:29 PM, Jason_000 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In notes.php
<#28 (comment)>:
> echo '<td>'."<input class='form-control' type=text name=note value=''> </td>";
echo '<td>'."<input class='btn btn-primary btn-outline' type=submit name=update value=Update".'> </td>';
- echo "<td style='display:none;'>".'<input type=hidden name=hidden value='.$row['uid'].'> </td>';
+ echo "<td style='display:none;'>".'<input type=hidden name=hidden value='.$row['playerid'].'> </td>';
I prefer the use of UID here over playerid due to 5.0 changing the table
to be pid.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANKRsLEV3hbpULLxhvRNdgYfXpiiiEQ6ks5r2PGngaJpZM4NFafn>
.
|
Allows the use of uid instead of playerid. Since all dbs use uid to link a player, there is no need to use playerid unless a new framework uses it.
Jason2605
reviewed
May 10, 2017
notes.php
Outdated
| @@ -80,8 +80,8 @@ | |||
| echo '<tr>'; | |||
| echo '<td>'.$row['uid'].' </td>'; | |||
| echo '<td>'.$row['name'].' </td>'; | |||
| echo '<td>'.$row['aliases'].' </td>'; | |||
| echo '<td>'."<select class='form-control' name='warn'><option value='4'>Commendation</option><option value='1' selected='selected'>Warning</option><option value='2'>Caution</option><option value='3'>Big Caution</option></select> </td>"; | |||
| echo '<td>'.$row['playerid'].' </td>'; | |||
|
I added row 83 to it for my own use, can be removed since it is not really
needed.
Connor
…On 10 May 2017 18:39, "Jason_000" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In notes.php
<#28 (comment)>:
> @@ -80,8 +80,8 @@
echo '<tr>';
echo '<td>'.$row['uid'].' </td>';
echo '<td>'.$row['name'].' </td>';
- echo '<td>'.$row['aliases'].' </td>';
- echo '<td>'."<select class='form-control' name='warn'><option value='4'>Commendation</option><option value='1' selected='selected'>Warning</option><option value='2'>Caution</option><option value='3'>Big Caution</option></select> </td>";
+ echo '<td>'.$row['playerid'].' </td>';
Same here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANKRsL6IMGBafIPPXBfrBPhvR5RGKQQTks5r4fY6gaJpZM4NFafn>
.
|
Removal of playerid being used (Still there on the concat search) and added so that the current warning points can be viewed.
Creates the warning column in the players table and adds a new table to use the for the staff notes. It uses the notes table already for the warning .
|
Very interesting concept. |
|
@Jason2605 might want to make your decisions whether or not to include this. Other contributions to the repo are creating conflicts. 🕐 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows warning points to be set in the players table with the same colum (warning) used in 'notes'. This does not create the colum in the 'players' table.
Other edit allows the warning points to be displayed on the users account information.