Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add padding option for inactive workspace numbers #702

Conversation

keonly
Copy link
Contributor

@keonly keonly commented Jan 8, 2025

Hi, I added an extra option to enable setting the paddings for inactive numbered workspaces.

  • Before
    snapshot_2025-01-09_05-19-20
    snapshot_2025-01-09_05-19-36
    (Notice the inconsistency of the workspace number positions!)
  • After (theme.bar.buttons.workspaces.numbered_inactive_padding = "0.4em";)
    snapshot_2025-01-09_05-18-47
    snapshot_2025-01-09_05-21-37

In both cases, I have set theme.bar.buttons.workspaces.numbered_active_highlight_padding to 0.4em. Please let me know what you think. Thanks for the great project!

@Jas-SinghFSU
Copy link
Owner

Is this different than the current Spacing option under Configuration > Bar > Workspaces > Spacing?

@keonly
Copy link
Contributor Author

keonly commented Jan 11, 2025

I found that the positions of the workspace buttons were still inconsistent when only bar.workspaces.spacing was adjusted.

Here is an example of such inconsistency when bar.workspaces.spacing is set to 2 and theme.bar.buttons.workspaces.numbered_active_highlight_padding is set to 0.4em.

snapshot_2025-01-11_16-12-28
snapshot_2025-01-11_16-12-42

@keonly
Copy link
Contributor Author

keonly commented Jan 11, 2025

Here are better visualisations of the change made in this PR!

  • Before (adjusted with spacing only)
before.mp4
  • After
after.mp4

@Jas-SinghFSU
Copy link
Owner

Jas-SinghFSU commented Jan 11, 2025

Nice, in that case we should probably remove the spacing option since this is more robust.
Scratch that since this only effects inactive workspaces.

@Jas-SinghFSU
Copy link
Owner

Jas-SinghFSU commented Jan 11, 2025

Can we move the Inactive Padding setting right below the Highlight Padding so it's logically grouped?

@keonly
Copy link
Contributor Author

keonly commented Jan 12, 2025

Updated! Would this be good?

@Jas-SinghFSU
Copy link
Owner

Yep, thanks for the contribution ❤️

@Jas-SinghFSU Jas-SinghFSU merged commit 88609f7 into Jas-SinghFSU:master Jan 16, 2025
1 check passed
FerranAD pushed a commit to FerranAD/HyprPanel that referenced this pull request Jan 17, 2025
…#702)

* feat: add padding option for inactive workspace number

* chore: reorder options to gather padding related options

---------

Co-authored-by: Jas Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants