-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated compression options in cql #4689
Replace deprecated compression options in cql #4689
Conversation
3694c4a
to
4b7cc43
Compare
ScyllaDB still uses the old options from Cassandra 2. Therefore, two different table initialization methods are needed to account for this difference. The incompatibility of compression options has been reported here: |
janusgraph-cql/src/main/java/org/janusgraph/diskstorage/cql/CQLKeyColumnValueStore.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @To-om ! Looks good to me. I have one commend below. Also, could you please squash your commits into a single commit?
Signed-off-by: toom <[email protected]>
b4975e7
to
f626a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @To-om !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing that change (+ in a backward compatible way!).
Closes discussion #4688
For all changes:
issuediscussion associated with this PR? Is it referenced in the commit message?issuediscussion number you are trying to resolve?master
)?For code changes:
For documentation related changes: