Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated compression options in cql #4689

Merged

Conversation

To-om
Copy link
Contributor

@To-om To-om commented Oct 8, 2024

Closes discussion #4688


For all changes:

  • Is there an issue discussion associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue discussion number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@To-om To-om force-pushed the cassandra5-compress-options branch from 3694c4a to 4b7cc43 Compare October 8, 2024 06:48
@To-om
Copy link
Contributor Author

To-om commented Oct 9, 2024

ScyllaDB still uses the old options from Cassandra 2. Therefore, two different table initialization methods are needed to account for this difference.

The incompatibility of compression options has been reported here:

Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @To-om ! Looks good to me. I have one commend below. Also, could you please squash your commits into a single commit?

docs/configs/janusgraph-cfg.md Outdated Show resolved Hide resolved
@To-om To-om force-pushed the cassandra5-compress-options branch from b4975e7 to f626a39 Compare October 28, 2024 08:59
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @To-om !

@porunov porunov added this to the Release v1.1.0 milestone Oct 29, 2024
@porunov porunov requested a review from cdegroc November 2, 2024 01:43
Copy link
Contributor

@cdegroc cdegroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing that change (+ in a backward compatible way!).

@porunov porunov merged commit a49d8e0 into JanusGraph:master Nov 4, 2024
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants