Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): setting agama flow as auth method #10539

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix(config-api): setting agama flow as auth method #10539

merged 5 commits into from
Jan 2, 2025
+26 −22

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jan 2, 2025 •
edited by devrimyatar
Loading

Prepare

Description

  1. Issue#10511: resolved error while setting agama flow as ACR

Target issue

closes #10511

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@pujavs pujavs requested review from yuriyz and yurem as code owners January 2, 2025 13:33
@pujavs pujavs requested a review from devrimyatar January 2, 2025 13:33
@mo-auto mo-auto added comp-docs Touching folder /docs comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pujavs pujavs mentioned this pull request Jan 2, 2025
Closed
@yuriyzz yuriyzz enabled auto-merge (squash) January 2, 2025 14:55
@yuriyzz yuriyzz merged commit 3c00152 into main Jan 2, 2025
2 checks passed
@yuriyzz yuriyzz deleted the jans-config-dev branch January 2, 2025 15:45
@mo-auto mo-auto mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyzz yuriyzz yuriyzz approved these changes

@devrimyatar devrimyatar devrimyatar approved these changes

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-docs Touching folder /docs comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-cli-tui): getting error when saving auth method as agama flow
5 participants
@pujavs @yuriyz @devrimyatar @yuriyzz @mo-auto