Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloud-native)!: remove couchbase support from OCI images #10132

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 13, 2024

Prepare


Description

Target issue

closes #10127

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-auth-server comp-docker-jans-casa Touching folder /docker-jans-casa comp-docker-jans-certmanager comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-kc-scheduler Touching folder /docker-jans-kc-scheduler comp-docker-jans-link comp-docker-jans-persistence-loader comp-docker-jans-saml Touching folder /docker-jans-saml comp-docker-jans-scim comp-jans-config-api Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-keycloak-link Touching folder /jans-keycloak-link comp-jans-link Touching folder /jans-link comp-jans-scim Component affected by issue or PR kind-dependencies Pull requests that update a dependency file labels Nov 13, 2024
Copy link

dryrunsecurity bot commented Nov 13, 2024

DryRun Security Summary

The pull request primarily focuses on removing support for Couchbase as a persistence backend and transitioning the Janssen Project applications to use SQL-based or hybrid persistence, while also updating various application configurations and component versions to maintain the security posture of the applications.

Expand for full summary

Summary:

The code changes in this pull request are primarily focused on removing support for Couchbase as a persistence backend and transitioning the Janssen Project applications to use SQL-based or hybrid persistence. This simplifies the codebase and reduces the attack surface by eliminating the need to handle Couchbase-specific vulnerabilities and configurations.

Additionally, the changes include updates to various application configurations, such as client redirect URIs, API dynamic configurations, and scope management. These updates help maintain the security posture of the applications by ensuring that the necessary security settings are in place and that the principle of least privilege is enforced.

The version updates for the Janssen Project components also suggest that the maintainers are actively addressing potential security vulnerabilities by incorporating the latest security fixes and improvements.

Files Changed:

  1. demos/benchmarking/docker-jans-loadtesting-jmeter/requirements.txt: The couchbase dependency has been removed from the requirements file, indicating a shift away from Couchbase as a data store.
  2. demos/benchmarking/docker-jans-loadtesting-jmeter/Dockerfile: The base image has been updated, and the Couchbase-related environment variables have been removed, with new RDBMS-related variables added.
  3. demos/benchmarking/docker-jans-loadtesting-jmeter/README.md: The documentation has been updated to reflect the changes in the user loading process, including the removal of Couchbase support.
  4. demos/benchmarking/docker-jans-loadtesting-jmeter/scripts/entrypoint.sh: The functionality to load users to Couchbase has been removed, and the focus is now on loading users to an RDBMS backend.
  5. docker-jans-auth-server/Dockerfile: The Couchbase-related environment variables have been removed, and the persistence type has been changed to SQL.
  6. docker-jans-all-in-one/Dockerfile: The Couchbase-related environment variables have been removed, and the JANS_SOURCE_VERSION has been updated.
  7. docker-jans-auth-server/README.md: The documentation has been updated to remove the Couchbase-related environment variables and configuration options.
  8. docker-jans-auth-server/scripts/bootstrap.py: The Couchbase-specific code has been removed, and the focus is now on SQL and hybrid persistence.
  9. docker-jans-auth-server/scripts/mod_context.py: The code for extracting and registering common libraries for the "couchbase" persistence type has been removed.
  10. docker-jans-auth-server/scripts/lock.py: The Couchbase-related code has been removed, and the focus is now on SQL-based persistence.
  11. docker-jans-auth-server/scripts/upgrade.py: The Couchbase-related code has been removed, and the focus is now on updating the client scopes and configurations.
  12. docker-jans-auth-server/templates/jans-auth/log4j2.xml: The Couchbase-related loggers have been removed.
  13. docker-jans-casa/README.md: The Couchbase support has been removed, and the documentation has been updated accordingly.
  14. docker-jans-casa/scripts/mod_context.py: The code for extracting and registering common libraries for the "couchbase" persistence type has been removed.
  15. docker-jans-casa/Dockerfile: The Couchbase-related environment variables have been removed, and the JANS_SOURCE_VERSION has been updated.
  16. docker-jans-casa/scripts/bootstrap.py: The Couchbase-related code has been removed, and the focus is now on SQL and hybrid persistence.
  17. docker-jans-casa/scripts/upgrade.py: The Couchbase-related code has been removed, and the focus is now on updating the client scopes and configurations.
  18. docker-jans-certmanager/README.md: The Couchbase support has been removed, and the documentation has been updated accordingly.
  19. docker-jans-certmanager/Dockerfile: The Couchbase-related environment variables have been removed, and the JANS_SOURCE_VERSION has been updated.
  20. `docker-jans-certman

Code Analysis

We ran 9 analyzers against 30 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 5 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@iromli iromli self-assigned this Nov 13, 2024
@iromli iromli marked this pull request as ready for review November 13, 2024 19:22
@iromli iromli requested a review from moabu as a code owner November 13, 2024 19:22
@moabu moabu merged commit eac6fd1 into main Nov 14, 2024
11 checks passed
@moabu moabu deleted the cn-image-del-couchbase branch November 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-all-in-one Touching folder /docker-jans-all-in-one comp-docker-jans-auth-server comp-docker-jans-casa Touching folder /docker-jans-casa comp-docker-jans-certmanager comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-kc-scheduler Touching folder /docker-jans-kc-scheduler comp-docker-jans-link comp-docker-jans-persistence-loader comp-docker-jans-saml Touching folder /docker-jans-saml comp-docker-jans-scim comp-jans-config-api Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-keycloak-link Touching folder /jans-keycloak-link comp-jans-link Touching folder /jans-link comp-jans-scim Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(cloud-native)!: remove couchbase support from OCI images
3 participants