-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jans-casa): primary button not changing color when customized via custom branding plugin #10084
Conversation
… custom branding plugin Signed-off-by: Jatin Mehta <[email protected]>
DryRun Security SummaryThe pull request modifies the CSS styles used in the "jans-casa" application, primarily focused on updating the visual styles of UI elements, without introducing any obvious security vulnerabilities, but the overall application's security posture should still be reviewed and tested to identify and address any potential security risks. Expand for full summarySummary: The code changes in this pull request appear to be focused on modifying the CSS styles used in the "jans-casa" application. The changes are made in the "css-component-rules.properties" file, which likely contains reusable CSS rules for various UI components. From a security perspective, the changes do not seem to introduce any obvious security vulnerabilities, as they are primarily focused on updating the visual styles of UI elements. However, it's important to note that while the code changes themselves may not directly impact security, the overall application's security posture should be considered. Factors such as input validation, access control, and secure coding practices should be reviewed to ensure the application is not vulnerable to common web application security issues (e.g., XSS, CSRF, SQL injection). Additionally, the use of third-party libraries or frameworks, if any, should be reviewed to ensure they are up-to-date and free from known vulnerabilities. Proper security testing, including both static and dynamic analysis, should be conducted to identify and address any potential security risks. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove z-button from tertiaryButton
Also, if btn
was removed from primary and third, is there some reason for secondaryButton
to have it ?
Signed-off-by: Jatin Mehta <[email protected]>
Quality Gate passed for 'jans-cli'Issues Measures |
|
closes #10053