Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-casa): primary button not changing color when customized via custom branding plugin #10084

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

mjatin-dev
Copy link
Contributor

closes #10053

Copy link

dryrunsecurity bot commented Nov 7, 2024

DryRun Security Summary

The pull request modifies the CSS styles used in the "jans-casa" application, primarily focused on updating the visual styles of UI elements, without introducing any obvious security vulnerabilities, but the overall application's security posture should still be reviewed and tested to identify and address any potential security risks.

Expand for full summary

Summary:

The code changes in this pull request appear to be focused on modifying the CSS styles used in the "jans-casa" application. The changes are made in the "css-component-rules.properties" file, which likely contains reusable CSS rules for various UI components.

From a security perspective, the changes do not seem to introduce any obvious security vulnerabilities, as they are primarily focused on updating the visual styles of UI elements. However, it's important to note that while the code changes themselves may not directly impact security, the overall application's security posture should be considered. Factors such as input validation, access control, and secure coding practices should be reviewed to ensure the application is not vulnerable to common web application security issues (e.g., XSS, CSRF, SQL injection). Additionally, the use of third-party libraries or frameworks, if any, should be reviewed to ensure they are up-to-date and free from known vulnerabilities. Proper security testing, including both static and dynamic analysis, should be conducted to identify and address any potential security risks.

Files Changed:

  • jans-casa/app/src/main/resources/css-component-rules.properties: This file contains the CSS styles used in the "jans-casa" application. The changes in this pull request appear to be focused on modifying the visual styles of various UI elements, such as buttons, inputs, and other components.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-casa Touching folder /jans-casa kind-bug Issue or PR is a bug in existing functionality labels Nov 7, 2024
Copy link
Contributor

@jgomer2001 jgomer2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove z-button from tertiaryButton

Also, if btn was removed from primary and third, is there some reason for secondaryButton to have it ?

Copy link

sonarqubecloud bot commented Nov 8, 2024

@mjatin-dev
Copy link
Contributor Author

z-button
I removed the z-button and also remove btn from secondary-button.

@duttarnab duttarnab enabled auto-merge (squash) November 11, 2024 07:04
@duttarnab duttarnab merged commit a1cd24b into main Nov 11, 2024
12 of 13 checks passed
@duttarnab duttarnab deleted the jans-casa-issue-10053 branch November 11, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-casa Touching folder /jans-casa kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-casa): primary button not changing color when customized via custom branding plugin
5 participants