Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloud-native)!: remove spanner support from OCI images #10055

Closed
wants to merge 4,495 commits into from

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 5, 2024

Prepare


Description

Target issue

closes #10046

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

devrimyatar and others added 30 commits August 30, 2024 12:08
* fix(jans-cli-tui): check response content type in cli mode

Signed-off-by: Mustafa Baser <[email protected]>

* fix(jans-cli-tui): don't post metadata location after editing saml-SP

Signed-off-by: Mustafa Baser <[email protected]>

---------

Signed-off-by: Mustafa Baser <[email protected]>
…ken call fails (#9312)

fix(jans-auth-server): if AS fails to allocate status index entire token call fails #9290

Signed-off-by: YuriyZ <[email protected]>
* feat(jans-cli-tui): config-api configuration

Signed-off-by: Mustafa Baser <[email protected]>

* fix(jans-cli-tui): display save info on dialog for config-api config

Signed-off-by: Mustafa Baser <[email protected]>

* docs(jans-cli-tui): config-api configuratios

Signed-off-by: Mustafa Baser <[email protected]>

* docs(jans-cli-tui): config-api swagger reference

Signed-off-by: Mustafa Baser <[email protected]>

* docs(config-api): update config api

Signed-off-by: ossdhaval <[email protected]>

* docs: edit the update section

Signed-off-by: ossdhaval <[email protected]>

* docs: proofreading changes

Signed-off-by: ossdhaval <[email protected]>

---------

Signed-off-by: Mustafa Baser <[email protected]>
Signed-off-by: ossdhaval <[email protected]>
Co-authored-by: ossdhaval <[email protected]>
* docs: update developer guide #8852

Signed-off-by: jgomer2001 <[email protected]>

* chore: disable super gluu extension #8852

Signed-off-by: jgomer2001 <[email protected]>

* chore: avoid image duplication #8847

Signed-off-by: jgomer2001 <[email protected]>

* chore: revert changes in login form #8852

Signed-off-by: jgomer2001 <[email protected]>

---------

Signed-off-by: jgomer2001 <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
* chore: update casa gitignore #8846

Signed-off-by: jgomer2001 <[email protected]>

* chore: remove unused files #9327

Signed-off-by: jgomer2001 <[email protected]>

* docs: re-arrange list of plugins #8852

Signed-off-by: jgomer2001 <[email protected]>

---------

Signed-off-by: jgomer2001 <[email protected]>
…records (#9334)

* feat(jans-config-api): update log/telemetry/health entries

Signed-off-by: Yuriy Movchan <[email protected]>

* feat(jans-config-api): update log/telemetry/health entries

Signed-off-by: Yuriy Movchan <[email protected]>

---------

Signed-off-by: Yuriy Movchan <[email protected]>
* feat: remove mounted files for sql persistence

Signed-off-by: iromli <[email protected]>

* feat: remove mounted files for couchbase persistence

Signed-off-by: iromli <[email protected]>

* feat: remove mounted files for ldap persistence

Signed-off-by: iromli <[email protected]>

* fix: handle hybrid persistence

Signed-off-by: iromli <[email protected]>

* feat: remove unused ldap-cron-pass secret

Signed-off-by: iromli <[email protected]>

Merging but its missing docs. Auto doc generator will take care of it.
---------

Signed-off-by: iromli <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
#9343)

feat(jans-config-api): add endpoint to load log/telemetery/health data for specific period

Signed-off-by: Yuriy Movchan <[email protected]>
* feat(jans-auth-server): AS supports acr aliasing but it's not published on discovery. It should be added to discovery. #9166

Signed-off-by: YuriyZ <[email protected]>

* feat(jans-auth-server): added acr_mappings to doc sample #9166

Signed-off-by: YuriyZ <[email protected]>

---------

Signed-off-by: YuriyZ <[email protected]>
…in id_token (#9358)

Signed-off-by: Arnab Dutta <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
* ci: forces download each time on packaging

Signed-off-by: moabu <[email protected]>

* ci: forces download each time on packaging

Signed-off-by: moabu <[email protected]>

---------

Signed-off-by: moabu <[email protected]>
Signed-off-by: Mohammad Abudayyeh <[email protected]>
…ly if using ldap persistence (#9323)

Signed-off-by: iromli <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
… /jans-bom (#9308)

chore(deps): bump com.mysql:mysql-connector-j in /jans-bom

Bumps [com.mysql:mysql-connector-j](https://github.com/mysql/mysql-connector-j) from 8.0.32 to 8.2.0.
- [Changelog](https://github.com/mysql/mysql-connector-j/blob/release/9.x/CHANGES)
- [Commits](mysql/mysql-connector-j@8.0.32...8.2.0)

---
updated-dependencies:
- dependency-name: com.mysql:mysql-connector-j
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… /jans-casa/app-fips (#8514)

chore(deps): bump org.bouncycastle:bc-fips in /jans-casa/app-fips

Bumps org.bouncycastle:bc-fips from 1.0.2.4 to 1.0.2.5.

---
updated-dependencies:
- dependency-name: org.bouncycastle:bc-fips
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/jans-bom (#6357)

chore(deps): bump org.apache.santuario:xmlsec in /jans-bom

Bumps org.apache.santuario:xmlsec from 2.2.4 to 2.2.6.

---
updated-dependencies:
- dependency-name: org.apache.santuario:xmlsec
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… /jans-config-api (#7911)

chore(deps-dev): bump org.bitbucket.b_c:jose4j in /jans-config-api

Bumps [org.bitbucket.b_c:jose4j](https://bitbucket.org/b_c/jose4j) from 0.9.3 to 0.9.4.
- [Commits](https://bitbucket.org/b_c/jose4j/branches/compare/jose4j-0.9.4..jose4j-0.9.3)

---
updated-dependencies:
- dependency-name: org.bitbucket.b_c:jose4j
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: use pythonic style #9181

Signed-off-by: jgomer2001 <[email protected]>
* feat(jans-core): update OpeDJ version

Signed-off-by: Yuriy Movchan <[email protected]>

* feat(jans-auth): set auth_user session attribute from authenticateByUserInum method

Signed-off-by: Yuriy Movchan <[email protected]>

---------

Signed-off-by: Yuriy Movchan <[email protected]>
* fix(config-api): asset mgt endpoint fixes

Signed-off-by: pujavs <[email protected]>

* feat(config-api): asset upload mgt ehancement and fido

Signed-off-by: pujavs <[email protected]>

* feat(config-api): asset upload mgt ehancement and fido

Signed-off-by: pujavs <[email protected]>

* feat(config-api): asset upload mgt ehancement and fido

Signed-off-by: pujavs <[email protected]>

* fix(config-api): asset upload

Signed-off-by: pujavs <[email protected]>

* fix(config-api): lock review comments

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock code review comments

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock master renamed to lock server

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock master renamed to lock server

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock master renamed to lock server

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock master renamed to lock server

Signed-off-by: pujavs <[email protected]>

* feat(config-api): fido2 delete functionality

Signed-off-by: pujavs <[email protected]>

* fix(config-api): acr validation

Signed-off-by: pujavs <[email protected]>

* feat(config-api): doc(config-api): IDP schema attribute descriptions #9187

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* feat(config-api): uploading assets via API generates 2 entries #9178

Signed-off-by: pujavs <[email protected]>

* feat(config-api): asset mgt, fido and IDP changes

Signed-off-by: pujavs <[email protected]>

* feat(config-api): fido2 device endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): fido2 endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): fido2 endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* feat(config-api): resolved sonar review issues

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sonar review comment fix

Signed-off-by: pujavs <[email protected]>

* feat(config-api): swagger spec

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml config attribute description

Signed-off-by: pujavs <[email protected]>

* doc(config-api): added SAML attribute description

Signed-off-by: pujavs <[email protected]>

* doc(config-api): added SAML attribute description

Signed-off-by: pujavs <[email protected]>

* feat(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* fix(jans-lock): code review comment fix isssue#9305

Signed-off-by: pujavs <[email protected]>

* fix(jans-lock): code review comment fix isssue#9305

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock review point

Signed-off-by: pujavs <[email protected]>

* fix(lock): code review comment

Signed-off-by: pujavs <[email protected]>

* fix(lock): code review comment

Signed-off-by: pujavs <[email protected]>

* fix(config-api): sync with main

Signed-off-by: pujavs <[email protected]>

* feat(config-api): lock endpoint fixes and SAML IDP NPE

Signed-off-by: pujavs <[email protected]>

---------

Signed-off-by: pujavs <[email protected]>
Co-authored-by: YuriyZ <[email protected]>
* Initializing branch for Cedarling MVP

Signed-off-by: Arnab Dutta <[email protected]>

* rust demo code without connect to python

* cargo improvements

* fix format rule

* add to gitignore files that is used in debug process

* add parsing roles from token and it mapping

* remove unused text in readme

* added guide how to build

* add python binding

* python example hotfix

* make Id in python example more illustrative

* update to make tokens field jti optional

* fix readme file

* feat: store the sample policy stores in demo folder #9373

Signed-off-by: Arnab Dutta <[email protected]>

* rename role mapper to token mapper

* add loading policy store from file or json

* show in example that we can use setter

* use single quote for action in python example

* update python bindings to use object Request

* add readme to demo data folder

* updated README.md

* update cedarling_python/README.md

---------

Signed-off-by: Arnab Dutta <[email protected]>
Co-authored-by: Arnab Dutta <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
…on backends (#9389)

* feat(jans-pycloudlib): handle required files for external configuration backends

Signed-off-by: iromli <[email protected]>

* feat(jans-pycloudlib): populate google credentials if using spanner persistence

Signed-off-by: iromli <[email protected]>

* fix(jans-pycloudlib): resolve broken dependency for google-cloud-secret-manager lib

Signed-off-by: iromli <[email protected]>

---------

Signed-off-by: iromli <[email protected]>
Co-authored-by: Mohammad Abudayyeh <[email protected]>
Copy link

dryrunsecurity bot commented Nov 5, 2024

DryRun Security Summary

The provided code changes focus on the removal of support for the Google Spanner persistence backend across various components of the Janssen project, simplifying the persistence layer and improving the overall security posture of the application.

Expand for full summary

Summary:

The provided code changes focus on the removal of support for the Google Spanner persistence backend across various components of the Janssen project. This simplification of the persistence layer is a positive security change, as it reduces the attack surface and complexity of the application. The changes also include updates to the configuration, client scopes, and logging for the Janssen Auth Server, Casa, and Config API applications, further improving the overall security posture of the project.

While the changes do not appear to introduce any immediate security vulnerabilities, it is essential to thoroughly review the updated configurations, dependencies, and persistence layer integrations to ensure that the application's security is not compromised. Factors such as secure credential management, input validation, and monitoring should be carefully evaluated to maintain the overall security of the Janssen project.

Files Changed:

  1. Requirements.txt: The google-cloud-spanner dependency has been removed, and the couchbase dependency has been added, indicating a shift in the project's persistence backend.
  2. Dockerfile: The environment variables related to Google Spanner have been removed, and the configuration has been updated to focus on Couchbase and SQL as the supported persistence types.
  3. Bootstrap.py: The code that handled the Spanner persistence backend has been removed, simplifying the application's setup and reducing the attack surface.
  4. Upgrade.py: The code changes focus on updating the client scopes, configurations, and persistence layer integrations to ensure a smooth upgrade process.
  5. mod_context.py: The changes remove the Spanner-related functionality and focus on managing the Couchbase persistence layer dependencies.
  6. README.md: The documentation has been updated to reflect the removal of the Spanner persistence type and the changes to the supported persistence configurations.

Code Analysis

We ran 9 analyzers against 30 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 5 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@iromli iromli marked this pull request as ready for review November 6, 2024 09:25
@iromli iromli requested a review from moabu as a code owner November 6, 2024 09:25
@iromli
Copy link
Contributor Author

iromli commented Nov 6, 2024

Superseded by #10070

@iromli iromli closed this Nov 6, 2024
@iromli iromli deleted the cn-image-rm-spanner branch November 6, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(cloud-native)!: remove spanner support from OCI images