Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump keycloak/keycloak from 25.0.6 to 26.0.5 in /docker-jans-saml #10026

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps keycloak/keycloak from 25.0.6 to 26.0.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from moabu as a code owner November 4, 2024 10:40
@dependabot dependabot bot added the docker Pull requests that update Docker code label Nov 4, 2024
@dependabot dependabot bot requested a review from iromli as a code owner November 4, 2024 10:40
@dependabot dependabot bot added the kind-dependencies Pull requests that update a dependency file label Nov 4, 2024
Copy link

dryrunsecurity bot commented Nov 4, 2024

DryRun Security Summary

The provided code change updates the Dockerfile for the "docker-jans-saml" project, focusing on improving security and maintainability by updating base images, installing additional packages, integrating a custom Keycloak plugin, synchronizing assets, installing Python dependencies, and setting a large number of environment variables, while also highlighting the need to review the custom components and configurations to ensure proper security and maintenance.

Expand for full summary

Summary:

This code change appears to be updating the Dockerfile for the "docker-jans-saml" project. The key changes include updating the base images for Keycloak and OpenJRE, installing additional Alpine packages, integrating a custom Keycloak plugin, synchronizing assets from the "jans-linux-setup" repository, installing Python dependencies, and setting a large number of environment variables.

From an application security perspective, the changes are generally positive, as they focus on keeping dependencies up-to-date, installing additional security-related packages, and running the container as a non-root user. However, there are a few areas that require closer attention:

  1. The custom "kc-jans-spi" Keycloak plugin should be reviewed for potential security vulnerabilities or misconfigurations, as it could introduce new attack vectors.
  2. The large number of environment variables, some of which may contain sensitive information, should be carefully managed and secured to prevent unauthorized access or exposure.
  3. The additional Alpine packages installed may introduce new attack surfaces, so it's important to ensure they are properly configured and maintained.

Overall, the changes appear to be focused on improving the security and maintainability of the Janssen project's Docker environment, but it's crucial to thoroughly review the custom components and configurations to ensure they are properly secured and maintained.

Files Changed:

  • docker-jans-saml/Dockerfile: This file has been updated to include the following changes:
    • Keycloak version updated from 25.0.6 to 26.0.5
    • OpenJRE version updated to the latest version
    • Additional Alpine packages installed, including openssl, python3, tini, curl, py3-cryptography, py3-psycopg2, py3-grpcio, and bash
    • "kc-jans-spi" Keycloak plugin downloaded and installed
    • Various static files and schemas synchronized from the "jans-linux-setup" repository
    • Python dependencies installed from a requirements.txt file
    • A large number of environment variables related to configuration, secrets, and persistence set
    • A non-root user created, and permissions adjusted accordingly

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@dependabot dependabot bot force-pushed the dependabot/docker/docker-jans-saml/keycloak/keycloak-26.0.5 branch from 0b357d8 to a3f71ab Compare November 4, 2024 17:58
@moabu
Copy link
Member

moabu commented Nov 7, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/docker/docker-jans-saml/keycloak/keycloak-26.0.5 branch 2 times, most recently from fbfb8dd to 835535b Compare November 12, 2024 03:51
@dependabot dependabot bot force-pushed the dependabot/docker/docker-jans-saml/keycloak/keycloak-26.0.5 branch 2 times, most recently from 52e25b6 to ef706ec Compare November 20, 2024 13:10
…jans-saml

Dependabot couldn't find the original pull request head commit, a3f71ab.
@dependabot dependabot bot force-pushed the dependabot/docker/docker-jans-saml/keycloak/keycloak-26.0.5 branch from ef706ec to 6fc7a1c Compare November 21, 2024 12:05
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 22, 2024

Superseded by #10240.

@dependabot dependabot bot closed this Nov 22, 2024
@dependabot dependabot bot deleted the dependabot/docker/docker-jans-saml/keycloak/keycloak-26.0.5 branch November 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant