fix(docker-jans-persistence-loader): handle missing data type for ove…

…rriden column (#8392) * fix(docker-jans-persistence-loader): handle missing data type for overriden column Signed-off-by: iromli <[email protected]> * fix: handle scripts properties changes Signed-off-by: iromli <[email protected]> * fix: handle non-collection properties Signed-off-by: iromli <[email protected]> --------- Signed-off-by: iromli <[email protected]>
JanssenProject · Apr 28, 2024 · 5b25766 · 5b25766
1 parent 96aa200
commit 5b25766
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/docker-jans-persistence-loader/scripts/spanner_setup.py b/docker-jans-persistence-loader/scripts/spanner_setup.py
@@ -46,6 +46,9 @@ def get_data_type(self, attr, table=None):
 
             type_ = type_def.get(self.client.dialect)
 
+            if not type_:
+                continue
+
             if table in type_.get("tables", {}):
                 type_ = type_["tables"][table]
 

diff --git a/docker-jans-persistence-loader/scripts/sql_setup.py b/docker-jans-persistence-loader/scripts/sql_setup.py
@@ -54,6 +54,9 @@ def get_data_type(self, attr, table=None):
 
             type_ = type_def.get(self.client.dialect) or type_def["mysql"]
 
+            if not type_:
+                continue
+
             if table in type_.get("tables", {}):
                 type_ = type_["tables"][table]
 

diff --git a/docker-jans-persistence-loader/scripts/upgrade.py b/docker-jans-persistence-loader/scripts/upgrade.py
@@ -369,9 +369,10 @@ def update_scripts_entries(self):
             else:
                 props = agama_entry.attrs["jansConfProperty"]
 
-            if self.backend.type != "couchbase":
-                # try converting to mapping
-                props = [json.loads(prop) for prop in props]
+            if not isinstance(props, list):
+                props = [props]
+
+            props = [json.loads(prop) for prop in props]
 
             # filter out unwanted properties
             new_props = [
@@ -380,8 +381,7 @@ def update_scripts_entries(self):
             ]
 
             if new_props != props:
-                if self.backend.type != "couchbase":
-                    new_props = [json.dumps(prop) for prop in new_props]
+                new_props = [json.dumps(prop) for prop in new_props]
 
                 if self.backend.type == "sql" and self.backend.client.dialect == "mysql":
                     agama_entry.attrs["jansConfProperty"]["v"] = new_props