Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: viewer stuck on loading if ocis images are not available #75

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix: viewer stuck on loading if ocis images are not available #75

merged 3 commits into from
Aug 29, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Aug 29, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: 🤚

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan saw-jan requested a review from S-Panta August 29, 2024 04:47
S-Panta
S-Panta approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually. This works

@saw-jan saw-jan merged commit 20dec19 into main Aug 29, 2024
1 check passed
@saw-jan saw-jan deleted the fix/issues-72 branch August 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-Panta S-Panta S-Panta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: viewer stuck on loading if ocis images are not available
2 participants
@saw-jan @S-Panta