Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #57, now name="name" is possible #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #57, now name="name" is possible #68

wants to merge 1 commit into from

Conversation

12finger
Copy link

fixes issue #57

@12finger 12finger mentioned this pull request Nov 12, 2015
Closed
@Jakobovski
Copy link
Owner

Thanks for the PR. Can you please follow the directions in https://github.com/turinggroup/angular-validator/blob/master/CONTRIBUTING.md.

Also can you change the code to use scopeForm.submitted instead of scope[main_form_name].submitted.

For example:if (scopeElementModel.$dirty || scopeForm.submitted)

@Jakobovski Jakobovski closed this Dec 1, 2015
@Jakobovski Jakobovski reopened this Dec 1, 2015
@12finger
Copy link
Author

12finger commented Jan 8, 2016

sorry for the long delay... i was too busy lately.
i will have a look at it and do the requested changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@12finger @Jakobovski