Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps to each message #34

Closed
wants to merge 1 commit into from
Closed

Add timestamps to each message #34

wants to merge 1 commit into from

Conversation

marczych
Copy link

@marczych marczych commented Sep 6, 2013

Enabled with the -t flag. Fixes #9

screen shot 2013-09-06 at 2 32 06 pm

Enabled with the -t flag. Fixes #9
@marczych
Copy link
Author

marczych commented Oct 1, 2013

@JakeWharton Just a friendly ping.

@JakeWharton
Copy link
Owner

This is kind of an eye sore. I was thinking about right-aligning the time and omitting the date and millis since they're relatively useless information.

@marczych
Copy link
Author

marczych commented Oct 1, 2013

I think the millisecond resolution is actually pretty useful when you get a flurry of logs in a short period of time. I agree with you about removing the date, though.

On the topic of making it pretty, it looks especially ugly when text wraps:
screen shot 2013-09-30 at 5 17 47 pm

I'm not sure what to do about that... I tried a different color to differentiate the timestamp from the log message but couldn't find one that I liked.

@vickychijwani
Copy link

Hi, I've rebased @marczych's commit to the latest master and resolved conflicts (specifically, between the -t short option for timestamps and the already existing -t flag for tags) in PR #82. This is a really useful feature, let's merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for timestamps
3 participants