Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gallery component #248

Merged
merged 5 commits into from
Oct 20, 2024
Merged

Conversation

Sawan-Kushwah
Copy link
Contributor

@Sawan-Kushwah Sawan-Kushwah commented Oct 17, 2024

issue #218

image

Screenshot 2024-10-17 200904

created a beautiful gallery components

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
glassyui ❌ Failed (Inspect) Oct 20, 2024 3:55pm

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for delightful-chaja-870050 ready!

Name Link
🔨 Latest commit 0e56f78
🔍 Latest deploy log https://app.netlify.com/sites/delightful-chaja-870050/deploys/671527c5556d700008c8498c
😎 Deploy Preview https://deploy-preview-248--delightful-chaja-870050.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for glassyui failed. Why did it fail? →

Name Link
🔨 Latest commit 0e56f78
🔍 Latest deploy log https://app.netlify.com/sites/glassyui/deploys/671527c5b373690008788401

@Jaishree2310
Copy link
Owner

@Sawan-Kushwah No its not looking good, i am sure you can enhance this more.
Also the basic usage code why it is so big and there is no customization props, etc
Please check the order of component given in the read me

@Sawan-Kushwah
Copy link
Contributor Author

Sawan-Kushwah commented Oct 18, 2024

image

image

@Jaishree2310 Added hover effect , glassmorphism class , and make the code more modulaar , seperated Images and put in array , also combined common classes in one variable and if extra classes need that can be passed in extra class variable , also added props for customization , Added space between images for clean and clear look !!

if more enhancement need then tell me !!

@Jaishree2310
Copy link
Owner

@Sawan-Kushwah Can you add basic usage and follow the component order given in the read me serial wise.

@Sawan-Kushwah
Copy link
Contributor Author

Sawan-Kushwah commented Oct 18, 2024

@Jaishree2310 okay please wait 5 min
in code they are serial wise should i provide you in comment also ?

@Sawan-Kushwah
Copy link
Contributor Author

Sawan-Kushwah commented Oct 18, 2024

@Jaishree2310
https://github.com/user-attachments/assets/8f6b9f9a-ac09-408b-953d-855e0ea57e81

I have added everything in sequence in code Please watch it

@Jaishree2310
Copy link
Owner

@Sawan-Kushwah Please resolve the conflicts

@Sawan-Kushwah
Copy link
Contributor Author

@Jaishree2310 done!

@Jaishree2310 Jaishree2310 merged commit 442e309 into Jaishree2310:main Oct 20, 2024
7 of 12 checks passed
@Jaishree2310 Jaishree2310 added gssoc-ext level3 45 points enhancement New feature or request labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext level3 45 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants