v10: Improved multi-store usage support #156
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leProvider` Replaced `FMTCTileProviderSettings.maxStoreLength` with `maxLength` on each store individually Exposed direct constructor for `FMTCTileProvider` Refactored and exposed tile provider logic into seperate `getBytes` method Added more `CacheBehavior` options Added toggle for hit/miss stat recording Added tests Improved documentation
3 tasks
Added internal `_DownloadManagerControlCmd` enum to better describe commands sent to/from the download manager thread (instead of numbers) Refactored download recovery startup to avoid waiting for manager thread to send already known information
Refactored `RootRecovery` singleton instance mangement to be class-internal
…y update when buffer cleared) Improved performance of bulk download thread buffer trackers
Added `StoreReadWriteBehavior` for improved customizability
Deprecated `obscuredQueryParams` Added `urlTransformer` & `urlTransformerOmitKeyValues` [as replacement for above Refactored `_FMTCImageProvider` internals
Added `DebuggingTileBuilder` to example app Fixed bugs
Improved performance of circle tile generation algorithm *Reduced* performance of circle tile count algorithm Improved performance of tile generation algorithms with specified `end`s
Updated NDK version for example app Upgraded actions for workflow Enabled caching of actions for workflow
…cted in example app) Fixed bug in internal `_sharedWriteSingleTile` where `writeAllNotIn` was not `null` Fixed bug when calculating `tileExistsInUnspecifiedStoresOnly` in `_internalGetBytes` (now `tileRetrievableFromOtherStoresAsFallback`) Renamed `TileLoadingInterceptorResult.tileExistsInUnspecifiedStoresOnly` to `.tileRetrievedFromOtherStoresAsFallback` & added `resultPath` requirement for truthy Renamed `TileLoadingInterceptorResultPath.noFetch` & `.fetched` to `.cacheAsFallback` & `.fetchedFromNetwork` respectively Added `FMTCTileProvider.otherStoresStrategy` & `.useOtherStoresAsFallbackOnly` management to example app Added storage of some settings to shared preferences in example app Minor internal improvements Minor documentation improvements
Improved CONTRIBUTING Minor improvements to `FMTCImageProvider`
Deprecated `BaseRegion` & `DownloadableRegion` `.when` & `.maybeWhen` Improved documentation
Discovered unintended behaviour
…xempt stores from `otherStoresStrategy`
…without `isRepeat` set Undeprecated `DownloadableRegion.(maybe)When`
Added `StackTrace` output to `TileLoadingInterceptorResult.error` (converted existing type to Record) Improved documentation Updated CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on v9, and fully embraces the new many-to-many relationship between tiles and stores to allow for more flexibility when constructing the tile provider.
This allows full & easy support for the ideas in #24 and #83: stores may now be treated as regions if wanted, which allows huge amounts of flexibility and a better UX.
Additionally, vector tiles are now supported in theory, as the internal caching/retrieval logic of the
ImageProviderhas been exposed, although it is out of scope to fully implement support for it.See CHANGELOG for full details.
(fixes #24)
(fixes #83)
(fixes #84)