Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(patch): Removing SQLx package #52

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore(patch): Removing SQLx package #52

merged 2 commits into from
Oct 25, 2024

Conversation

Jacobbrewer1
Copy link
Owner

@Jacobbrewer1 Jacobbrewer1 commented Oct 25, 2024

Describe your changes

If users are using the sqlx package for their databases, then they can call the WithDB opt and pass in the DB object that is part of the sqlx struct.

sqlxDb := sqlx.Open("mysql", "some-conn-str")
opt := patcher.WithDB(sqlxDb.DB)

This closes #51

@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) October 25, 2024 06:44
@Jacobbrewer1 Jacobbrewer1 disabled auto-merge October 25, 2024 06:45
@Jacobbrewer1 Jacobbrewer1 merged commit e2e3b62 into main Oct 25, 2024
6 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the chore/#51 branch October 25, 2024 06:47
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Move loader methods too a separate package
1 participant