Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create rpm package #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Create rpm package #47

wants to merge 2 commits into from

Conversation

JPZ13
Copy link

@JPZ13 JPZ13 commented Dec 17, 2024

Related to #37.

Description

This PR:

  • Builds an RPM package for the repo
  • Updates some of the DKMS config

Notes:

  • I've built the package on COPR at this link
  • I don't have much experience with RPM packaging or DKMS, so feedback is very welcome
  • I don't have a machine where I can test this out. I'm using Bazzite for my home distro and am looking to loop this into akmods and test from there
  • If this is working well, I can also build a Github Action to build the package on new releases

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Hardcode version

Signed-off-by: J.P. Zivalich <[email protected]>

use prior art

Signed-off-by: J.P. Zivalich <[email protected]>

Remove unknown fields

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Add description

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Add changelog

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Add date to changelog

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Update changelog

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Update

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Change setup to configure repo

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Change name

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Update names

Signed-off-by: J.P. Zivalich <[email protected]>

chore: comment out items

Signed-off-by: J.P. Zivalich <[email protected]>

chore: Start from 0

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Fix version

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Run make

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Add dkms steps

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Switch module to name

Signed-off-by: J.P. Zivalich <[email protected]>

fix: Add global key

Signed-off-by: J.P. Zivalich <[email protected]>
Signed-off-by: J.P. Zivalich <[email protected]>
@JPZ13
Copy link
Author

JPZ13 commented Dec 17, 2024

I don't have permission to request reviews, but tagging @Lawstorant and @JacKeTUs for visibility. Thank you for maintaining the AUR package and the repo, respectively

@JPZ13 JPZ13 changed the title chore: Add rpm spec chore: Create rpm package Dec 17, 2024
@@ -1,8 +1,8 @@
PACKAGE_NAME="universal-pidff"
PACKAGE_VERSION="0.0.12"
PACKAGE_VERSION="0.0.10"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this shouldn't change in this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll flip it back

Comment on lines +5 to +6
BUILT_MODULE_NAME[0]="universal-pidff"
DEST_MODULE_NAME[0]="universal-pidff"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why module name is changed here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll flip this back as well

@JacKeTUs JacKeTUs self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants