Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch link checker to lychee (and let it run more often) #532

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 17, 2024

The current action https://github.com/gaurav-nelson/github-action-markdown-link-check/ is not maintained any more.

We switch to https://github.com/lycheeverse/lychee, which is also used in the main repository. Refs #526 (comment).

This also enables link checking on push and on a regular basis. Due to a limiation of the GitHub workflow syntax, the checks are done both on push and on PR creation, meaning they run twice.

@koppor
Copy link
Member Author

koppor commented Oct 17, 2024

OMG, Lychee has issues with escaped underscores - which could be a show-stopper when using it with GitBook: lycheeverse/lychee#1529

@koppor
Copy link
Member Author

koppor commented Oct 17, 2024

But it works here, so I go ahead.

@koppor koppor merged commit 730dc64 into main Oct 17, 2024
2 of 4 checks passed
@koppor koppor deleted the update-link-checks branch October 17, 2024 07:24
koppor added a commit that referenced this pull request Oct 17, 2024
Tridecatrix pushed a commit to Tridecatrix/user-documentation that referenced this pull request Oct 17, 2024
Tridecatrix pushed a commit to Tridecatrix/user-documentation that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant