Skip to content

Commit

Permalink
Merge branch 'main' into fix-for-issue-435
Browse files Browse the repository at this point in the history
  • Loading branch information
Tridecatrix authored Oct 17, 2024
2 parents b805788 + 07493a9 commit 4dda475
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-links.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Check external href links in the documentation
name: Check links

on:
push:
Expand Down
Binary file added en/.gitbook/assets/workflow-check-results.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
39 changes: 19 additions & 20 deletions en/contributing/how-to-improve-the-help-page.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,36 +54,35 @@ That's it! The JabRef team will review your changes and publish them on [docs.ja

To edit more than one file at a time, add screenshots, and for other more advanced changes, we recommend that you checkout this repository locally and create a Pull Request of your changes using the standard git and GitHub workflow.

### Tables
### CI

The best way to enter tables is to use this [Table Generator](http://www.tablesgenerator.com/markdown\_tables) for Markdown. It has the nice feature to generate markdown tables from different sources, e.g. you can directly copy the table from a spreadsheet or upload a csv file. Just copy and paste the generated markdown into the documentation.
Two CI jobs (called "workflows" in GitHub terminology) are triggered each time you push or pull request.

### How to regenerate `SUMMARY.md` from scratch
- Lint workflow checks for minor Markdown formatting style issues.

Use <https://github.com/koppor/gitbook-summary-generator>.
- Check links workflow checks for broken links, e.g. to images or external resources.

On PRs, you are able to view the results directly on the PR (though you have to wait for a maintainer to approve running the workflow). You can also view the results on the local fork of the repo that you pushed to (which you are recommended to check first so you can fix mistakes before the maintainer has to look at it).

On your local fork, you can check the results of the workflows in the Actions tab > All actions panel on Github as shown below. Click on a specific workflow and its run to check the results.

### How to find broken links
![Actions tab on Github](../.gitbook/assets/workflow-check-results.png)

1. Install [markdown-link-check](https://github.com/tcort/markdown-link-check): `npm install -g markdown-link check`
2. `find . -name \*.md -exec markdown-link-check -qq {} \; > bad-links.txt`
### Notes on links workflow

### How to find Markdown errors
Links to external resources that aren't essential should be added to `.lycheeignore`. Resources can change URL or be taken down, and it isn't the best use of contributor resources to constantly keep fixing them, so try to spare us the headache!

You can use the [markdown-lint docker image](https://github.com/marketplace/actions/markdown-linting-action):
Note that check links may fail on links which you did not modify in your changes, in which case you can ignore them. Just do make sure that you don't introduce any additional broken links.

```shell
docker run --rm \
-v "$(pwd):/tmp/check" \
-e INPUT_CONFIG=/tmp/check/.markdownlint.yml \
avtodev/markdown-lint:v1 \
/tmp/check/en
```
TEMPORARY NOTE: until [issue #533](https://github.com/JabRef/user-documentation/issues/533) is fixed, you will actually find a _lot_ of broken links.

Alternatively, you can run the GitHub Lint workflow:
### Tables

The best way to enter tables is to use this [Table Generator](http://www.tablesgenerator.com/markdown\_tables) for Markdown. It has the nice feature to generate markdown tables from different sources, e.g. you can directly copy the table from a spreadsheet or upload a csv file. Just copy and paste the generated markdown into the documentation.

```shell
act --rm --platform ubuntu-latest=fwilhe2/act-runner:latest -W .github/workflows/lint.yaml
```
### How to regenerate `SUMMARY.md` from scratch

Use <https://github.com/koppor/gitbook-summary-generator>.

### How to rename files

Expand Down

0 comments on commit 4dda475

Please sign in to comment.