Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to FileColumn allowing mouse click access to multiple files(.md, .png, etc.) #12085

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

gabenogu
Copy link
Contributor

@gabenogu gabenogu commented Oct 25, 2024

…by mouse click.

Describe the changes you have made here: There was an issue when opening files such as .md or .png that were linked to a BibText entry. We made changes to the FileColumn that added an event listener allowing for the click to be registered for different files(I.E. multiple file extensions).
Closes #12005

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Thanks, overall looks already good, just some minor code style so far. Need to take a closer look at the functionality and a review from a second maintainer

@subhramit subhramit added status: waiting-for-feedback The submitter or other users need to provide more information about the issue status: changes required Pull requests that are not yet complete labels Oct 26, 2024
@koppor koppor removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 31, 2024
@koppor
Copy link
Member

koppor commented Oct 31, 2024

@gabenogu Please fix "OpenRewrite". Execute gradle task "rewriteRun", comit and push the update to here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@gabenogu gabenogu requested a review from subhramit November 1, 2024 15:03
subhramit
subhramit previously approved these changes Nov 1, 2024
@Siedlerchr Siedlerchr enabled auto-merge November 1, 2024 17:31
@Siedlerchr
Copy link
Member

thanks for your contribution! The PR will be now merged automatically. Do not push any more changes

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 1, 2024
Merged via the queue into JabRef:main with commit f0e8d74 Nov 1, 2024
23 checks passed
@subhramit
Copy link
Member

subhramit commented Nov 1, 2024

@Siedlerchr sorry for the premature approval from my end, i assumed checkstyle issues were fixed and only checked openrewrite test on my phone

@Siedlerchr
Copy link
Member

Siedlerchr commented Nov 1, 2024

All fine! checkstyle was green but there was still the "supress" line

@koppor
Copy link
Member

koppor commented Nov 1, 2024

@Siedlerchr do we need a changelog entry for this?

@Siedlerchr
Copy link
Member

Siedlerchr commented Nov 1, 2024 via email

@koppor koppor mentioned this pull request Nov 2, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clicking on a file icon in the extra column, the file should be opened.
5 participants