-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to FileColumn allowing mouse click access to multiple files(.md, .png, etc.) #12085
Conversation
src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/maintable/MainTableColumnModel.java
Outdated
Show resolved
Hide resolved
Thanks, overall looks already good, just some minor code style so far. Need to take a closer look at the functionality and a review from a second maintainer |
src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java
Outdated
Show resolved
Hide resolved
@gabenogu Please fix "OpenRewrite". Execute gradle task "rewriteRun", comit and push the update to here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
thanks for your contribution! The PR will be now merged automatically. Do not push any more changes |
@Siedlerchr sorry for the premature approval from my end, i assumed checkstyle issues were fixed and only checked openrewrite test on my phone |
All fine! checkstyle was green but there was still the "supress" line |
@Siedlerchr do we need a changelog entry for this? |
Yeah would be nice to have one. Maybe as changed
|
…by mouse click.
Describe the changes you have made here: There was an issue when opening files such as .md or .png that were linked to a BibText entry. We made changes to the FileColumn that added an event listener allowing for the click to be registered for different files(I.E. multiple file extensions).
Closes #12005
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)