Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change linter #10614

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Change linter #10614

merged 4 commits into from
Nov 6, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 2, 2023 •
edited
Loading

This changes the markdown external ink checker from markdown-link-check to lychee

Reasons

Status Count
🔍 Total 1699
✅ Successful 817
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 882
❓ Unknown 0
🚫 Errors 0

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. The issues found can be automatically fixed. Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

@koppor koppor marked this pull request as draft November 2, 2023 15:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

While the PR was in progress, JabRef released a new version. You have to merge upstream/main and move your entry in CHANGELOG.md to section ## [Unreleased].

It might also be that another CHANGELOG.md issue arose. You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "CHANGELOG.md".

@koppor koppor changed the title Update mlc_config.json Change linter Nov 2, 2023
@koppor koppor marked this pull request as ready for review November 2, 2023 21:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 2, 2023
@Siedlerchr Siedlerchr enabled auto-merge November 3, 2023 18:48
@calixtus
Copy link
Member

calixtus commented Nov 3, 2023

grafik

@koppor
Copy link
Member Author

koppor commented Nov 6, 2023

Change in CHANGELOG.md frozen sections is OK, because I fixed links there.

@koppor koppor disabled auto-merge November 6, 2023 04:42
@koppor koppor merged commit 837fc1e into main Nov 6, 2023
19 of 21 checks passed
@koppor koppor deleted the koppor-patch-1 branch November 6, 2023 04:42
Siedlerchr added a commit to shawn-jj/jabref that referenced this pull request Nov 6, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-10509
97fa0c9 
* upstream/main:
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
@koppor koppor mentioned this pull request Nov 8, 2023
Draft
Siedlerchr added a commit to lisongxuan/jabref that referenced this pull request Nov 9, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into Issue#10556-Search-…
c95d0e8 
…Selected

* upstream/main:
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 10, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-348
373dec5 
* upstream/main: (24 commits)
  Add support for scite.ai (JabRef#10617)
  Update tests.yml (JabRef#10631)
  replace "SearchAll" in web search by "Search Selected" (JabRef#10611)
  Use System preference for light dark theme (JabRef#10593)
  Fix NPE in lookup identifer
  Add minimum requirements to CHANGELOG.md (JabRef#10628)
  Update to JavaFX 21.01 (JabRef#10627)
  Fix JabRef#10498 Create Fetcher and Transformer for ScholarArchive (JabRef#10549)
  fix tests
  Bump org.jsoup:jsoup from 1.16.1 to 1.16.2 (JabRef#10625)
  Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1
  Bump org.fxmisc.flowless:flowless from 0.7.1 to 0.7.2
  Bump com.dlsc.gemsfx:gemsfx from 1.84.0 to 1.90.0
  Bump com.tngtech.archunit:archunit-junit5-api from 1.1.0 to 1.2.0
  Change linter (JabRef#10614)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @calixtus @Siedlerchr