Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When clicking on a file icon in the extra column, the file should be opened. #12005

Closed
koppor opened this issue Oct 17, 2024 · 5 comments · Fixed by #12085
Closed

When clicking on a file icon in the extra column, the file should be opened. #12005

koppor opened this issue Oct 17, 2024 · 5 comments · Fixed by #12085
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@koppor
Copy link
Member

koppor commented Oct 17, 2024

  1. Create a bib entry
  2. Attach a Markdown (.md) file to it (via drag and drop)
  3. Configure an extra entry table column to show Markdown files as described at Added documentation for extra file columns user-documentation#526
  4. The entry table now has a Markdown column
    Image
  5. Click on the icon
  6. See that nothing happens

Expected behavior: Markdown editor opens.

Double check: If clicking on the file column, the editor opens

Image

@koppor koppor added the [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs label Oct 17, 2024
@koppor koppor added this to the 6.0 milestone Oct 17, 2024
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Oct 17, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Oct 17, 2024
@gabenogu
Copy link
Contributor

Hello, my name is Gabriel. I am working with a group of student developers from FIU and we would love to work on this issue. Thank you!

@koppor
Copy link
Member Author

koppor commented Oct 18, 2024

/assign @gabenogu

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Oct 18, 2024
Copy link
Contributor

👋 Hey @,

Thanks for your interest in this issue! 🎉

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within ** days**.

🔧 A maintainer can also add the **** label to prevent it from being unassigned automatically.

Happy coding! 🚀

@koppor koppor moved this from Free to take to Assigned in Good First Issues Oct 18, 2024
@gabenogu
Copy link
Contributor

Good morning, so me and my group were looking at the issue and came up with some ideas but we were wondering where specifically to look in the IDE or repository in general to write the logic. Thank you for the help!

@Siedlerchr
Copy link
Member

@gabenogu as a starting point I would look here in the MainTableColumnFactory

case EXTRAFILE:
if (!column.getQualifier().isBlank()) {
returnColumn = createExtraFileColumn(column);
}
break;
case SPECIALFIELD:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty. [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
Status: Done
3 participants