Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for g-keys combinations #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ginden
Copy link

@Ginden Ginden commented Feb 11, 2021

Related to #32 and #15

@Ginden
Copy link
Author

Ginden commented Jun 30, 2021

@JSubelj Hey, any news on this PR?

@suabo
Copy link
Collaborator

suabo commented Nov 9, 2022

Hi and thank you for your pull request.
I looked through it and thought a little bit about it. To make this feature work you need one gkey macro set to nothing or something not interrupting if you use a combination. I just thought of normal shortcuts. They always use keys that don't do anything if press on their own like strg, shift or maybe alt. The problem i see is that if you configured all your gkeys it is most likely you will not only run the command on the combination. If you don't manage to press the keys at the very same time the key you press first will also fire and run the configured macro. A much better way to add more macros would be to add support for strg+g[1-9] and shift+g[1-9]. I would also prefer to take the right strg and shift keys for combinations.

I would like to hear another opinion on this topic.

Since I merged a lot of other pull request there is also a lot of conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants