Allow async/await when intercepting synchronous methods #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 229 229
Branches 7 7
=====================================
Hits 229 229Continue to review full report at Codecov.
|
JSkimming
force-pushed
the
async-with-sync
branch
from
0aadec2 to
172c940
Compare
JSkimming
force-pushed
the
async-with-sync
branch
from
c51bf7b to
781409f
Compare
JSkimming
force-pushed
the
async-with-sync
branch
from
781409f to
7dbd2cd
Compare
|
It's been fixed now in Castle.Core |
|
YAY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #26 has highlighted an issue whereby interceptors that derive from AsyncInterceptorBase can result in deadlock when executing asynchronous operations when intercepting synchronous methods.
This PR as attempting to address that underlying deadlock issue before addressing the problem raised by PR #26 and issue #25.