Check for user-ticket requirements on purchase order creation #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
fforres
force-pushed
the
fforres/check_for_requirements
branch
from
dc9bcfc to
c20f37c
Compare
joseglego
reviewed
Dec 2, 2024
| where: (ut, { and, eq, inArray }) => | ||
| and( | ||
| eq(ut.userId, userId), | ||
| inArray(ut.approvalStatus, [ |
There was a problem hiding this comment.
Creo que tenemos una variable para esto porque se volvió recurrente en la App
ACCESSIBLE_USER_TICKET_APPROVAL_STATUSES
joseglego
reviewed
Dec 2, 2024
| expect, | ||
| beforeEach, | ||
| expectTypeOf, | ||
| } from "vitest"; |
joseglego
reviewed
Dec 2, 2024
| @@ -0,0 +1,23 @@ | |||
| CREATE TABLE IF NOT EXISTS "ticket_requirements" ( | |||
| "ticket_id" uuid NOT NULL, | |||
| "required_ticket_id" uuid NOT NULL, | |||
There was a problem hiding this comment.
SI tenemos requirement_type creo que este ID es complicado! Al menos que tengamos un campo adicional para required_category_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.