Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise coap request node (along the lines of the http request node) #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JKRhb
Copy link
Owner

@JKRhb JKRhb commented Mar 16, 2021

This PR will update the coap request node to function more similar to the http request node from the core package.

@JKRhb JKRhb self-assigned this Mar 16, 2021
@JKRhb JKRhb force-pushed the request-rework branch 3 times, most recently from b6973c8 to e11ad5f Compare September 21, 2021 02:33
@coveralls
Copy link

coveralls commented Apr 3, 2022

Pull Request Test Coverage Report for Build 2178199913

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 40 (55.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-5.5%) to 75.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
coap/coap-request.js 22 40 55.0%
Files with Coverage Reduction New Missed Lines %
coap/coap-request.js 6 76.92%
Totals Coverage Status
Change from base Build 2178198039: -5.5%
Covered Lines: 162
Relevant Lines: 210

💛 - Coveralls

@JKRhb JKRhb force-pushed the request-rework branch from 9aa7114 to 306185f Compare June 1, 2022 19:55
@JKRhb JKRhb force-pushed the request-rework branch 4 times, most recently from 735720c to f3130e6 Compare January 2, 2023 08:33
@JKRhb JKRhb force-pushed the request-rework branch 2 times, most recently from d2a222d to 5bd74e4 Compare July 4, 2024 18:39
@JKRhb JKRhb force-pushed the request-rework branch from 5bd74e4 to 96742c2 Compare July 4, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants