Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chloropleth eGRID and NTD scripts #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpfleischer
Copy link
Contributor

@jpfleischer jpfleischer commented Dec 18, 2024

efficiency.ipynb plots NTD data using UACE shapefiles. Specifically, fuel efficiency and average passengers are plotted.

chloropleth.ipynb plots eGRID data using EPA provided shapefiles. 2014, 2020, and 2022 data are visualized, including deltas across those years.

The code was written such that any external files that are needed should be automatically downloaded. The only files needed are the ntd json files which should already be checked in with this repo, if not, may need to run ntd.ipynb again.

Copy link
Collaborator

@Abby-Wheelis Abby-Wheelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fairly clean to me! My only concern is with the chloropleth notebook there seems to be lots of duplicate code. Are both versions needed? Is there anything that could be done to cut down on that duplication?

@JGreenlee
Copy link
Owner

JGreenlee commented Dec 19, 2024

I'll be the first to admit that the existing notebooks are really bulky and monolithic. Extracting more of that code out into reusable functions (in script_utils.py or another file) would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants