-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
인기순 게시글 조회 API 구현 #762
Merged
Merged
인기순 게시글 조회 API 구현 #762
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2798108
feat: 인기순 게시글 조회 API 구현
jschoi-96 eb2f5b1
Merge branch 'main' into feat/757-popular-tag-api-create
jschoi-96 09a6813
style: sonarqube
jschoi-96 0c5c122
Merge remote-tracking branch 'origin/feat/757-popular-tag-api-create'…
jschoi-96 04e1e99
Merge branch 'main' into feat/757-popular-tag-api-create
jschoi-96 5671933
style: sonarqube
jschoi-96 17d6f66
Merge remote-tracking branch 'origin/feat/757-popular-tag-api-create'…
jschoi-96 657a7c2
Merge branch 'main' into feat/757-popular-tag-api-create
jschoi-96 a98edee
feat: 하나의 API 엔드포인트로 통합
jschoi-96 5123b78
Merge remote-tracking branch 'origin/feat/757-popular-tag-api-create'…
jschoi-96 90c4c29
style: sonarqube
jschoi-96 e60454c
feat: 서비스 메서드를 하나로 통합하여 분기처리
jschoi-96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
처음 API 명세서를 보는 사람 입장에서, "/best"와 "/popular-games" 이 두 API가 어떤 차이를 보이는지 알기 어려울 것 같아요.
아래처럼 하나의 API 엔드포인트에서 쿼리 파라미터를 통해 두 가지 조회 방식을 처리하는 것은 어떨까요?
이렇게 하면 코드의 간결함과 유연함이 향상될 것 같아요.
만약 2개의 API로 분리하고 싶다면, 둘을 명확하게 구분할 수 있도록 URI라도 개선하는게 좋아보여요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good idea.