Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 메인 페이지 모바일 UI 구현 #255
base: dev
Are you sure you want to change the base?
feat: 메인 페이지 모바일 UI 구현 #255
Changes from 33 commits
0e89460
5785e4f
7889a18
bf378ee
9e1cf04
9b93298
2e34267
6d7999c
9cbf5fa
c79b191
d253605
9e04430
5a64243
640137f
7c40e26
4df0893
da1caea
f9dfd3f
11e0e37
5f794bc
7f838d2
f7f8bd1
1ca657c
def69e0
376bc7b
683110a
4bd8535
0c7ea14
a87da2f
9aa65cb
9d33708
408850c
d62a7fc
27311d2
ca6ad6e
d3c5a97
d2f2cda
5e33858
1f6d5d5
738de7e
bb112d2
2605268
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
아이콘 크기 관리 방식 개선 필요
현재 동일한 아이콘에 대해 일반 크기와 작은 크기 버전을 별도의 SVG 파일로 관리하고 있습니다. 이는 다음과 같은 문제를 야기할 수 있습니다:
SVG 파일을 하나로 통합하고 width와 height 속성을 주입하는 방식으로 변경하는 것을 추천드립니다. 예시:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아름님 pr도 중복되는 부분이 있어서 추후 하나로 통일되면 좋을 거 같네요..! 추가로 해당 pr에도 언급했듯 기존 svg에 width와 height를 주입해주는 방식이 효율적이라고 생각합니다!