Partitioning + pytest #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lr4d, @ara080808, @florian-jetter-jdas: please take a look |
kagharpure
force-pushed
the
partitioning_pytest
branch
from
579152d to
0502297
Compare
lr4d
requested changes
Nov 11, 2019
kagharpure
force-pushed
the
partitioning_pytest
branch
from
84e2209 to
33f3d16
Compare
lr4d
requested changes
Nov 11, 2019
fjetter
requested changes
Nov 12, 2019
|
@fjetter - sorry for pushing this urgently. Please let me know if my responses to your comments are satisfactory. Also, please let me know if you have a strong opinion on |
fjetter
requested changes
Nov 12, 2019
kagharpure
force-pushed
the
partitioning_pytest
branch
2 times, most recently
from
4f02a1f to
2e78411
Compare
Test partitioning on multiple columns Add pytest Fix failing build on travis
kagharpure
force-pushed
the
partitioning_pytest
branch
from
2e78411 to
2d94da6
Compare
fjetter
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test script more modular
Test partitioning on multiple columns
Add a pytest alternative for testing