Add gradle build for the plugin #1

kandoeniko · 2019-04-17T11:42:54Z

configure the appveyor and travis
jobs

tephe · 2019-04-17T12:03:03Z

build.gradle

+}
+
+group = 'com.ullink.gradle'
+description 'Uses sonar-scanner-msbuild to do static analysis with Sonarqube.'


Is this the description we want?

Nope, fixed it. Thanks!

tephe

I think this project should be named gradle-extentreports-csharp-plugin, not dotnet, because it uses the extentreports-csharp project. Then it would be easier to find by others :)

- configure the appveyor and travis jobs - add empty plugin in order to have the setup done correctly for the plugin

kandoeniko · 2019-04-17T12:46:59Z

Actually the reporting framework is called extentreports-dotnet-cli, so I think it is ok with the current naming (to avoid having the csharp part in the name)

ngyukman · 2019-04-23T04:58:44Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGenerator.groovy

+class ReportGenerator extends Exec {
+
+    def EXTENT_REPORT_TYPE = 'v3html'
+    def EXTENT_REPORT_DOWNLOAD_URL = 'https://www.nuget.org/api/v2/package/extent/0.0.3'


can extract the version as separated property so project can upgrade to newer version easily?

I thought about it. But it actually defines just the style of the generated html. I don't think we will actually configure this or have a lot of changes, so I let it be as it is for now.

ngyukman · 2019-04-23T04:59:37Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGenerator.groovy

+
+class ReportGenerator extends Exec {
+
+    def EXTENT_REPORT_TYPE = 'v3html'


property that can be configured should use camel case not upper cases

I thought that this was the convention for consts in groovy :)

for constant yes, but it is now defined as a property of the task

dfev77 · 2019-04-30T08:28:27Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGenerator.groovy

+            ensureExtentReportIsAvailable()
+            generateReports()
+        } else {
+            project.logger.info("There is no available Test Result file based on which the report should be generated located at ${project.tasks.nunit.getTestReporthPath()}")


put a wrapper method around project.tasks.nunit.getTestReportPath() as it is used in multiple places

dfev77 · 2019-04-30T08:32:51Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGenerator.groovy

+        return new File(extentReportFolder, EXTENT_REPORT_EXECUTABLE_PATH)
+    }
+
+    void downloadExtentReport() {


can we separate the download of extent in a separate plugin and have this plugin depend on that?
Just to keep things cleaner

- use the extent-report framework - generate report once NUnit or OpenCover finished generating the report - added unit tests for report generation

ngyukman · 2019-07-11T03:51:09Z

build.gradle

+    authorId 'ekando'
+    authorName 'Kando Eniko'
+    authorEmail '[email protected]'
+    projectUrl "https://github.com/Ullink/${project.name}"


it's Itiviti now :)

Suggested change

projectUrl "https://github.com/Ullink/${project.name}"

projectUrl "https://github.com/Itiviti/${project.name}"

ngyukman · 2019-07-11T03:51:48Z

build.gradle

+}
+
+plugindev {
+    pluginName 'com.ullink.gradle:gradle-extentreports-dotnet-plugin'


as a new plugin we should use the new group name com.itiviti

ngyukman · 2019-07-11T03:53:44Z

build.gradle

+
+bintray {
+    user project.properties.bintrayUser
+    key project.properties.bintrayApiKey


from the plugindev documentation, bintray closure can be put after plugindev and it will assign user and key correctly

Ok, so if I understood correctly, I just need to move it after the plugindev and there is no need to specifically set the user & key ?

yes, it should be the case

ngyukman · 2019-07-11T03:54:12Z

build.gradle

+        [group: 'com.ullink.gradle', name: 'gradle-nunit-plugin', version: '1.14'],
+        [group: 'com.ullink.gradle', name: 'gradle-opencover-plugin', version: '1.13']
+    )
+    testCompile 'junit:junit:4.11'


don't think junit is needed to add explicitly when spock is used

ngyukman · 2019-07-11T03:54:57Z

gradle.properties

@@ -0,0 +1 @@
+version=1.0


following semver is better, so it would be 1.0.0

ngyukman · 2019-07-11T03:59:55Z

src/main/groovy/com/ullink/gradle/extentreport/ExtentReportDotnetPlugin.groovy

+    void apply(Project project) {
+
+        Task extentReportDownloaderTask = project.task('reportDownload', type: ReportGeneratorDownloader)
+        Task reportingTask = project.task('nunitReport', type: ReportGenerator)


should add task group and description to show the task from ./gradlew tasks see here

ngyukman · 2019-07-11T04:00:58Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGenerator.groovy

+
+class ReportGenerator extends Exec {
+
+    def ExtentReportType = 'v3html'


naming should be camel case

Suggested change

def ExtentReportType = 'v3html'

def extentReportType = 'v3html'

ngyukman · 2019-07-11T04:03:26Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGeneratorDownloader.groovy

+
+class ReportGeneratorDownloader extends Download {
+
+    def EXTENT_REPORT_DOWNLOAD_URL = 'https://www.nuget.org/api/v2/package/extent/0.0.3'


it should be camel case as well
furthermore, usually we try to extract the version out so we can upgrade easily, like opencover or nunit

ngyukman · 2019-07-11T04:05:41Z

src/main/groovy/com/ullink/gradle/extentreport/ReportGeneratorDownloader.groovy

+    }
+
+    void downloadExtentReport() {
+        def downloadedFile = new File(getTemporaryDir(), EXTENT_REPORT_DOWNLOADED_FILE_NAME)


you can do getTemporaryDir().createNewFile() instead, as the name is not really necessary to be a constant / variable

ngyukman · 2019-07-11T04:07:00Z

src/test/groovy/com/ullink/ExtentReportDotnetPluginTest.groovy

+import spock.lang.Specification
+
+class ExtentReportDotnetPluginTest extends Specification{
+    @Rule TemporaryFolder testProjectDir = new TemporaryFolder()


in spock, good thing is you don't need to new for the Rule

Suggested change

@Rule TemporaryFolder testProjectDir = new TemporaryFolder()

@Rule TemporaryFolder testProjectDir

kandoeniko force-pushed the master branch 3 times, most recently from e443eba to 89600d4 Compare April 17, 2019 12:03

tephe reviewed Apr 17, 2019

View reviewed changes

kandoeniko force-pushed the master branch from 89600d4 to 038c614 Compare April 17, 2019 12:35

Add gradle build for the plugin

c702b6d

- configure the appveyor and travis jobs - add empty plugin in order to have the setup done correctly for the plugin

kandoeniko force-pushed the master branch from 038c614 to c702b6d Compare April 17, 2019 12:44

kandoeniko force-pushed the master branch 2 times, most recently from 3a78ca1 to c437425 Compare April 18, 2019 14:22

timotei approved these changes Apr 19, 2019

View reviewed changes

ngyukman reviewed Apr 23, 2019

View reviewed changes

dfev77 approved these changes Apr 30, 2019

View reviewed changes

dfev77 suggested changes Apr 30, 2019

View reviewed changes

ngyukman approved these changes May 24, 2019

View reviewed changes

kandoeniko force-pushed the master branch from c437425 to e1cffb5 Compare July 10, 2019 07:04

Generate report file based on TestResult

9d070ca

- use the extent-report framework - generate report once NUnit or OpenCover finished generating the report - added unit tests for report generation

kandoeniko force-pushed the master branch from e1cffb5 to 9d070ca Compare July 10, 2019 07:34

ngyukman reviewed Jul 11, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add gradle build for the plugin #1

Add gradle build for the plugin #1

kandoeniko commented Apr 17, 2019

tephe Apr 17, 2019

kandoeniko Apr 17, 2019

tephe left a comment

kandoeniko commented Apr 17, 2019

ngyukman Apr 23, 2019 •

edited

Loading

kandoeniko Apr 24, 2019

ngyukman Apr 23, 2019

kandoeniko Apr 24, 2019

ngyukman Apr 29, 2019

kandoeniko Jul 10, 2019

dfev77 Apr 30, 2019

dfev77 Apr 30, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

kandoeniko Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019

ngyukman Jul 11, 2019


		class ReportGenerator extends Exec {

		def EXTENT_REPORT_TYPE = 'v3html'

	projectUrl "https://github.com/Ullink/${project.name}"
	projectUrl "https://github.com/Itiviti/${project.name}"


		class ReportGenerator extends Exec {

		def ExtentReportType = 'v3html'


		class ReportGeneratorDownloader extends Download {

		def EXTENT_REPORT_DOWNLOAD_URL = 'https://www.nuget.org/api/v2/package/extent/0.0.3'

	@Rule TemporaryFolder testProjectDir = new TemporaryFolder()
	@Rule TemporaryFolder testProjectDir

		@@ -0,0 +1 @@
		version=1.0

Add gradle build for the plugin #1

Are you sure you want to change the base?

Add gradle build for the plugin #1

Conversation

kandoeniko commented Apr 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tephe left a comment

Choose a reason for hiding this comment

kandoeniko commented Apr 17, 2019

ngyukman Apr 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngyukman Apr 23, 2019 •

edited

Loading