Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with() method to Block #37

Conversation

lukasbesch
Copy link
Contributor

Updated from 0.2.1 to 0.4.0 and ran into fatal errors because my blocks don't define a with method.

I propose adding a method to the extendable Block class just to be safe.

@tangrufus
Copy link
Contributor

I think adding abstract public function with(): array to AbstractBlock is a better choice.

Besides, we should have an interface for AbstractBlock.

@codepuncher
Copy link
Member

Closed in favour of #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants