Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for extra image in metadata and to move image preview out of traits #127

Merged
merged 10 commits into from
Apr 8, 2024

Conversation

newbreedofgeek
Copy link
Member

@newbreedofgeek newbreedofgeek commented Apr 6, 2024

To fix:

#126

#125

bucurdavid and others added 2 commits April 5, 2024 10:23
@damienen
Copy link
Member

damienen commented Apr 6, 2024

Preview can be moved out of traits, but it's debatable if it should be moved as it allows people to quickly see the preview from the marketplace.

The bonus image trait is redundant as we should just use the MultiversX NFT standard
Screenshot_20240406-145302
That would mean actively using the assets URIs. Those can be however many we want, more cam be updated to make the NFTs upgradable, etc.

@damienen
Copy link
Member

damienen commented Apr 6, 2024

@newbreedofgeek
Copy link
Member Author

newbreedofgeek commented Apr 6, 2024

that's fine, but we are going to aim to build this to be multi-chain compatible so we can bridge data nfts.

[UPDATE] But as per our discussions on the side, we will support BOTH adding to MvX NFT "Assets" and also on the NFT Metadata

@newbreedofgeek
Copy link
Member Author

Looks good @damienen

Once confirmed to work via an alpha pubish on NPM and used by Data DEX, we can merge to develop.

@damienen damienen merged commit cfd0547 into develop Apr 8, 2024
2 checks passed
@newbreedofgeek newbreedofgeek deleted the feature-support-bonusimg branch November 11, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants