refactor: error handling and File import

Refs: #25
Itheum · Sep 20, 2023 · a6339cb · a6339cb
1 parent 7427c54
commit a6339cb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/common/mint-utils.ts b/src/common/mint-utils.ts
@@ -1,4 +1,4 @@
-import { NFTStorage } from 'nft.storage';
+import { NFTStorage, File } from 'nft.storage';
 
 export async function dataNFTDataStreamAdvertise(
   dataNFTStreamUrl: string,

diff --git a/src/errors.ts b/src/errors.ts
@@ -7,6 +7,11 @@ export class ErrNetworkConfig extends Error {
   }
 }
 
+export class ErrArgumentNotSet extends Error {
+  public constructor(argument: string, message?: string) {
+    super(`Argument "${argument}" is not set. ${message}`);
+  }
+}
 export class ErrInvalidArgument extends Error {
   public constructor(message: string) {
     super(`Invalid argument: ${message}`);

diff --git a/src/nft-minter.ts b/src/nft-minter.ts
@@ -25,6 +25,7 @@ import {
   storeToIpfs
 } from './common/mint-utils';
 import { ContractConfiguration } from './interfaces';
+import { ErrArgumentNotSet } from './errors';
 
 export class NftMinter extends Minter {
   /**
@@ -234,13 +235,10 @@ export class NftMinter extends Minter {
 
     if (!imageUrl) {
       if (!nftStorageToken) {
-        throw new Error(
+        throw new ErrArgumentNotSet(
+          'nftStorageToken',
           'NFT Storage token is required when not using custom image and traits'
         );
-        // throw new ErrArgumentNotSet(
-        //   'nftStorageToken',
-        //   'NFT Storage token is required when not using custom image and traits'
-        // );
       }
       const { image, traits } = await createFileFromUrl(
         `${this.imageServiceUrl}/v1/generateNFTArt?hash=${dataNftHash}`,