Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: creator can withdraw and bond again #6

Merged
merged 2 commits into from
Mar 15, 2024
Merged

feat: creator can withdraw and bond again #6

merged 2 commits into from
Mar 15, 2024

Conversation

bucurdavid
Copy link
Member

Refs: #1

@bucurdavid bucurdavid requested a review from damienen March 14, 2024 15:31
@github-actions GitHub Actions
Copy link

Coverage after merging develop into main

93.97%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   admin.rs100%100%100%
   config.rs100%69.23%89.19%10, 11, 17, 9
   lib.rs100%100%100%
   views.rs100%86.96%86.51%..., 189, 190, 82, 96
src/contexts
   bond_cache.rs100%66.67%74.36%..., 45, 46, 47, 48
   compensation_cache.rs100%66.67%61.54%..., 46, 47, 48, 49
src/contexts/mappers
   object_to_id_mapper.rs100%100%99.13%165

@github-actions GitHub Actions
Copy link

Coverage after merging develop into main

93.97%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   admin.rs100%100%100%
   config.rs100%69.23%89.19%10, 11, 17, 9
   lib.rs100%100%100%
   views.rs100%86.96%86.51%..., 189, 190, 82, 96
src/contexts
   bond_cache.rs100%66.67%74.36%..., 45, 46, 47, 48
   compensation_cache.rs100%66.67%61.54%..., 46, 47, 48, 49
src/contexts/mappers
   object_to_id_mapper.rs100%100%99.13%165

damienen
damienen approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@damienen damienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gotta remove the comments, else is good for me (can be done with the other changes)

@bucurdavid bucurdavid merged commit 35e1e66 into main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienen damienen damienen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bucurdavid @damienen