-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of batch.inc and added Drush command #39
Open
janjouketjalsma
wants to merge
16
commits into
Islandora:7.x
Choose a base branch
from
LeidenUniversityLibrary:master
base: 7.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
de51965
Always update last_modified
janjouketjalsma 165d181
Merge branch 'release/0.1'
janjouketjalsma 036584f
Finish rewrite
ae5bf4f
Merge branch 'release/7.x-1.10-rewritten-batch'
e76e2e1
Better use of coding standards
dbacc0b
Differentiate between error conditions
5a3c9ea
Improve docblock
05ad737
Move arguments to options and add validation of all options
66d9eae
Fix incorrect validation
e94b9ff
Fixed bug introduced while working on error conditions
945897c
Improve error text
235171d
Update README.md
janjouketjalsma c0e6dbe
small fix: coding standards
b07f8fc
Merge branch 'develop' of https://github.com/LeidenUniversityLibrary/…
087dcf1
Improved Drush integration and fixed bug in chunk_size calculation. T…
843330d
Merge branch 'release/7.x-1.10-rewritten-batch-rc1'
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janjouketjalsma If you are going to change this variable name, you should add a
hook_update_N()
function to migrate the old setting fromislandora_xmlsitemap_number_of_pids_to_process
toislandora_xmlsitemap_generate_limit_cron
and then unset theislandora_xmlsitemap_number_of_pids_to_process
variable. Otherwise it will hang around forever.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, the old refrain, "Don't forget the uninstall hook!"
islandora_xmlsitemap_uninstall() - the variable name should be updated there too.