added check #1031
Merged
added check #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't the display not be defining |
|
from Tech call:
|
adam-vessey
reviewed
Jun 26, 2024
rosiel
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue 1030: (link)
What does this Pull Request do?
If an Islandora installation does not use Fedora then viewing a media object will cause a fatal error
What's new?
A check for $fedora_root has been added to islandora_entity_view
How should this be tested?
Delete or comment out the flysystem config from settings.php, then try to view a media
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
@Islandora/committers