Updating Manual Install Instructions Based on Feedback from slangerx #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosiel
reviewed
Jul 10, 2024
|
Should be ready to go now. |
rosiel
approved these changes
Jul 17, 2024
Comment on lines
-69
to
-88
| ### Creating a New Solr Core | ||
|
|
||
| Initially, our new Solr core will contain a configuration copied from the example included with the installation, so that we have something to work with when we configure this on the Drupal side. We’ll later update this with generated configurations we create in Drupal. | ||
|
|
||
| ```bash | ||
| cd /opt/solr | ||
| sudo mkdir -p /var/solr/data/SOLR_CORE/conf | ||
| sudo cp -r example/files/conf/* /var/solr/data/SOLR_CORE/conf | ||
| sudo chown -R solr:solr /var/solr | ||
| sudo -u solr bin/solr create -c SOLR_CORE -p 8983 | ||
| ``` | ||
| - `SOLR_CORE`: `islandora8` | ||
|
|
||
| You should see an output similar to this: | ||
| ``` | ||
| WARNING: Using _default configset with data driven schema functionality. NOT RECOMMENDED for production use. | ||
| To turn off: bin/solr config -c islandora8 -p 8983 -action set-user-property -property update.autoCreateFields -value false | ||
|
|
||
| Created new core 'islandora8' | ||
| ``` |
There was a problem hiding this comment.
Why was this removed? The rest of the page refers to "the core we created earlier" but there is no core now
There was a problem hiding this comment.
Update: it looks like this was just moved down to line 134. IMO this needs to be updated to be in the right order. I can make this change without objection
There was a problem hiding this comment.
@forresthopkinsa , this PR has been merged already, but if you would like to propose any edits, you can do it on https://github.com/Islandora/documentation/blob/main/docs/installation/manual/installing-solr.md
Comment on lines
+284
to
+285
| Edit the commons config to update it with Fedora's location (if necessary) and enable the apix middleware in `/opt/crayfish/Milliner/config/packages/crayfish_commons.yaml`: | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / why
@slangerx contributed edits to the manual install instructions and posted it as an issue @ #2326. This PR pulls in most of those suggestions and provides a few small additions.
What changes were made?
Lots of updates to the various manual install steps.
Verification
Please check formatting, spelling, grammar, etc.
Interested Parties
Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:
Person Merging
The person merging should ensure the following: