Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to latest buildkit tag #63

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Point to latest buildkit tag #63

merged 1 commit into from
Sep 9, 2024

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Sep 5, 2024

The old tag was failing to build

Closes #62

@joecorall joecorall marked this pull request as ready for review September 5, 2024 12:18
@joshdentremont
Copy link
Contributor

I think we had talked about purposefully not using main when we pushed this PR through - #42 - but I don't see any conversation about it, so it might have been during a tech call

@joecorall
Copy link
Contributor Author

@joshdentremont - honestly I thought it was already set to main after #49 resulted in https://github.com/Islandora-Devops/isle-site-template?tab=readme-ov-file#set-environment-properties

@joshdentremont
Copy link
Contributor

Looks like that bit never happened, but maybe was intended to. I'm OK with this PR changing it back to main since it is clearly documented.

Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aOelschlager aOelschlager merged commit 8d9b0d2 into main Sep 9, 2024
6 checks passed
@aOelschlager aOelschlager deleted the buildkit-tag branch September 9, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing inconsistently
3 participants