Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Access Control #98

Closed

Conversation

kylehuynh205
Copy link
Contributor

@kylehuynh205 kylehuynh205 commented Jul 4, 2023

About this PR:

Required modifications from isle-dc

Modules

Islandora Group Module

  • Module Link: https://github.com/digitalutsc/islandora_group
  • Based from Danny's initial works, by tagging nodes, then it will move the node and its media into Groups, and Group will handle the access control.
  • this module will extend from Danny work to apply access control for node and media separately and provide an UI to move nodes and media to group(s)

image

image

Group Solr

  • Module Link: https://github.com/digitalutsc/group_solr
  • Purpose: prevent restricted node(s) not being included in Search Results and Facet results counter. This ensure the accuracy for the Advanced Search module.
  • Components:

Private File Adapter

For ingesting Sample content with Workbench

Requirements:

To ingest node and media with access control with Islandora Workbench:

                "field_access_terms": [{
                    "target_id": 55,
                    "target_type": 'taxonomy_term'
                }]

Note: Replace 55 with the tid of term associated with newly created Group

Further development

kylehuynh205 and others added 30 commits May 15, 2023 14:14
Add Islandora Group module to composer
kylehuynh205 and others added 13 commits May 18, 2023 09:01
Update Main in June 15 and merge ongoing work of access control
Added Search hightlight field for search views
Change Advanced Search module to the beta release
…starter-site into islandora_group

* 'search_highlight' of github.com:kylehuynh205/islandora-starter-site:
  Update version of Advanced Search include fixes for https://github.com/digitalutsc/advanced_search/issues/33 and Islandora-Devops#96 (comment)
  Update composer.lock
  Enable Search hightlight settings for Search API Added Search hightlight field for search views Change Advanced Search module to the beta release
  Bump JWT.
  Update jwt

# Conflicts:
#	composer.lock
@kylehuynh205 kylehuynh205 marked this pull request as ready for review July 4, 2023 18:30
@@ -158,6 +158,22 @@ This should get you a starter Islandora site with:
* RDF and JSON-LD mappings for miscellaneous entities to support storage in
Fedora, Triplestore indexing and client requests.

### Private file system

* In Drupal container of isle-dc, create private file system directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Starter Site is not specific to ISLE-dc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test it with playbook and isle-site-template as well.

"type": "package",
"package": {
"name": "islandora/advanced_search",
"version": "2.0.0-beta3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specify this commit? The starter site should update with new versions (non-breaking).

composer.json Outdated
"mjordan/islandora_workbench_integration": "^1.0"
"mjordan/islandora_workbench_integration": "^1.0",
"digitalutsc/group_solr": "^1.0.0-beta",
"digitalutsc/islandora_group": "^1.0.0-beta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually the syntax is @beta (2 lines)/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with the commit kylehuynh205@abc5726

@kylehuynh205 kylehuynh205 deleted the islandora_group branch July 6, 2023 05:09
@kylehuynh205
Copy link
Contributor Author

Redone with #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants