C-01 Fix [PAG] #95
Merged
C-01 Fix [PAG] #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
junkim012
commented
May 12, 2024
•
junkim012
commented
- Rename getUnderlyingClaimOf => balanceOf
- Rename balanceOf => normalizedBalanceOf
- Rename getTotalUnderlyingClaimsUnaccrued => totalSupplyUnaccrued
- Rename getTotalUnderlyingClaims => totalSupply
- Rename totalSupplyUnaccrued => normalizedTotalSupplyUnaccrued
- Rename totalSupply => normalizedTotalSupply
- Change the name of functions being used in IonPool and Vault according to the change above.
… reallocate, accrue fee when feePercentage is updated
…o small now returns minimum base rate instead of reverting
…s must only be renaming function names
C-01 Fix [PAG]
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Closed
Merged
Merged
Merged
Merged
… the next iteration
… cannot violate either max caps
…upply scaled by distribution factor truncates to zero
…ssets and shares, the factory enforces initial deposit into the vault at deployment time
H-01 Fix [PAG]
M-02 Fix [PAG]
L-04 Fix [PAG]
L-03 Fix [PAG]
L-10 Fix [PAG]
M-05 Fix [PAG]
M-04 Fix [PAG]
L-09 Fix [PAG]
L-07 Fix [PAG]
M-08 Fix [PAG]
… IERC4626 inheritdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.