Vault and Core Upgrade #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions to IonLens to reduce codesize (tests failing)
Vault and Core Upgrade
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
junkim012
force-pushed
the
jun/lending-vault
branch
from
fe87bef to
8eba0ad
Compare
junkim012
force-pushed
the
jun/lending-vault
branch
from
46ce60b to
61ee14b
Compare
…ol/ion-protocol into hrikb/transferability
junkim012
force-pushed
the
jun/lending-vault
branch
from
e8954cf to
0f78d89
Compare
… the next iteration
… cannot violate either max caps
…upply scaled by distribution factor truncates to zero
…ssets and shares, the factory enforces initial deposit into the vault at deployment time
H-01 Fix [PAG]
M-02 Fix [PAG]
L-04 Fix [PAG]
L-03 Fix [PAG]
L-10 Fix [PAG]
M-05 Fix [PAG]
M-04 Fix [PAG]
L-09 Fix [PAG]
L-07 Fix [PAG]
M-08 Fix [PAG]
… IERC4626 inheritdoc
C-01 Fix [PAG]
HrikB
previously requested changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges PR #69
This PR includes three different changes.
1. Ion Lending Vault
Users who want exposure to multiple markets on Ion can deposit into a vault managed by a third party. This third party can receive deposits and rebalance all deposits across multiple pairs. For example, if users deposit 100 wstETH into the vault, the vault manager can distribute the asset by lending 20 wstETH into the weETH/wstETH market, 50 wstETH into the rsETH/wstETH market, and 30 wstETH into the rswETH market.
2. IonPool & RewardToken Upgrade
RewardTokenfollowing ERC20 interface.RewardTokenfrom the rebasing token to a non-rebasing token.balanceOffunction, renaming functions such that the amount of normalized shares is exposed as the balance of the token. This change was made such that we do not have to create a separate 4626 wrapper for the rebasing lender receipt token.3. Ion Lens
A lens contract for view functions and exposing the storage of IonPool used in upgradeability.
1. This change is included in the
/srcfiles changed in the PR, but it only deals with view functions and does not have any impact on the protocol.