Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump HLS to 1.8 #4871

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Bump HLS to 1.8 #4871

merged 3 commits into from
Oct 3, 2022

Conversation

michaelpj
Copy link
Contributor

Let hydra go at this.

@michaelpj michaelpj requested a review from zeme-iohk September 30, 2022 13:59
@michaelpj
Copy link
Contributor Author

Linux built, tested locally and it works. Just waiting for darwin to build on hydra.

@michaelpj michaelpj merged commit ae9312a into master Oct 3, 2022
@jbgi
Copy link
Contributor

jbgi commented Oct 4, 2022 •
edited
Loading

I think this PR silently removed all windows jobs: https://hydra.iohk.io/eval/1284943#tabs-removed
Eg. now:

$ nix build -f release.nix mingwW64.haskell.library.word-array
[...]
Error: cabal: Could not resolve dependencies:
[__0] next goal: cardano-crypto-class (user goal)
[__0] rejecting: cardano-crypto-class-2.0.0 (conflict: pkg-config package
libsodium-any, not found in the pkg-config database)
[__0] fail (backjumping, conflict set: cardano-crypto-class)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: cardano-crypto-class

related upstream issue: input-output-hk/haskell.nix#1666

@jbgi
Copy link
Contributor

jbgi commented Oct 4, 2022

Fix in https://github.com/input-output-hk/plutus/pull/4881/files

This was referenced Oct 4, 2022
Closed
Open
@michaelpj
Copy link
Contributor Author

The haskell.nix bump just made things silently not work any more??? 😱

@kwxm kwxm deleted the mpj/hls-1.8 branch November 10, 2022 13:30
brainrake pushed a commit to mlabs-haskell/plutus that referenced this pull request Dec 8, 2022
@michaelpj @brainrake
Bump HLS to 1.8 (IntersectMBO#4871)
3ac5f89 
* Bump HLS to 1.8

* Roots only

* Revert "Roots only"

This reverts commit 7c1039c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeme-iohk zeme-iohk zeme-iohk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelpj @jbgi @zeme-iohk